[RF] Fixing memory leak in RooAbsCollection::find#18359
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Apr 11, 2025
Merged
[RF] Fixing memory leak in RooAbsCollection::find#18359guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
TomasDado
changed the title
silverweed
reviewed
Apr 11, 2025
TomasDado
force-pushed
the
MemoryFixRooAbsCollection
branch
from
8756400 to
52f7bac
Compare
silverweed
approved these changes
Apr 11, 2025
Contributor
silverweed
left a comment
silverweed
left a comment
There was a problem hiding this comment.
LGTM but maybe wait for @guitargeek 's approval too
Test Results 18 files 18 suites 5d 7h 56m 49s ⏱️ For more details on these failures, see this check. Results for commit 52f7bac. |
ferdymercury
approved these changes
Apr 11, 2025
guitargeek
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes memory leaks found by valgrind. Similar to #18327
Checklist: