Fixing memory leak in RooAbsCollection::find

Tomas Dado · Tomas Dado · commit 875640095a64 · 2025-04-11T10:06:57.000+02:00
diff --git a/roofit/roofitcore/src/RooAbsCollection.cxx b/roofit/roofitcore/src/RooAbsCollection.cxx
@@ -951,6 +951,8 @@ RooAbsArg * RooAbsCollection::find(const RooAbsArg& arg) const
 
   if (_hashAssistedFind || _list.size() >= _sizeThresholdForMapSearch) {
     if (!_hashAssistedFind || !_hashAssistedFind->isValid()) {
+      if (_hashAssistedFind)
+         delete _hashAssistedFind;
       _hashAssistedFind = new HashAssistedFind{_list.begin(), _list.end()};
     }
 

Original file line number	Diff line number	Diff line change
`@@ -951,6 +951,8 @@ RooAbsArg * RooAbsCollection::find(const RooAbsArg& arg) const`
`951`	`951`
`952`	`952`	`if (_hashAssistedFind \|\| _list.size() >= _sizeThresholdForMapSearch) {`
`953`	`953`	`if (!_hashAssistedFind \|\| !_hashAssistedFind->isValid()) {`
	`954`	`+ if (_hashAssistedFind)`
	`955`	`+ delete _hashAssistedFind;`
`954`	`956`	`_hashAssistedFind = new HashAssistedFind{_list.begin(), _list.end()};`
`955`	`957`	`}`
`956`	`958`