Skip to content

perf: skip micromark + innerHTML for plain text without markdown syntax (#145) #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohal12 merged 8 commits into from
Mar 28, 2026
Merged

perf: skip micromark + innerHTML for plain text without markdown syntax (#145) #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39e94ff
docs: add design spec for renderNodes plain text fast path (issue #145)
Mar 27, 2026
512cab1
docs: add implementation plan for renderNodes plain text fast path (#…
Mar 27, 2026
935924b
test: add correctness baseline tests for renderNodes plain text fast …
Mar 28, 2026
57d5974
fix: disable block-level markdown inside inline HTML elements
Mar 28, 2026
158e296
fix: skip micromark + innerHTML for plain text without markdown synta…
Mar 28, 2026
8ed6f3f
test: add benchmark for renderNodes plain text fast path (#145)
Mar 28, 2026
81fb155
fix: add + and = to markdown syntax detection regex (#145)
Mar 28, 2026
3d0c96c
plans
Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .worktrees/feat-storage-management
Open in desktop
Submodule feat-storage-management added at cee58c
12 changes: 12 additions & 0 deletions dev/story.twee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ A wooden door stands to the north. Through a crack beneath it, you see flickerin

[[Code passages->Code Passages Test]] | [[Watch triggers->Watch Tests]] | [[Dialog API->Dialog API Tests]] | [[SVG test->SVG Interop]]

[[Consecutive set->Consecutive Set Test]]

[[Nested HTML include->Nested HTML Include Test]] | [[Button HTML test->Button HTML Test]]

:: Hallway
Expand Down Expand Up @@ -1259,6 +1261,16 @@ This is a programmatic dialog. It was opened via Story.openDialog().
:: Dialog API Second
This is the second queued dialog.

:: Consecutive Set Test
{include "Consecutive Set Sub"}

[[Start]]

:: Consecutive Set Sub [nobr]
{set _x = [3, 1, 2]}
{set _y = _x.slice().sort()}
Result: {_y}

:: Button HTML Test
**Button with HTML block element inside:**

Expand Down
Loading
Loading