perf: skip micromark + innerHTML for plain text without markdown syntax (#145)#146
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…path (#145) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Inline elements like <span>, <em>, <a> should not produce block-level markdown constructs (lists, headings, blockquotes). Added INLINE_ELEMENTS set and inline option to markdownToHtml to disable these constructs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
#145) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These were missing from MARKDOWN_SYNTAX_RE: + is a CommonMark list marker (like - and *), = is used for setext heading underlines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Release preview: merging this PR will publish v0.43.4 (patch bump from v0.43.3) |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderNodes: After building the combined string, detect when text contains no markdown-triggering characters and build vnodes directly — bypassing both micromark andinnerHTML. Eliminates ~655 innerHTML calls on plain UI text like "ALMA", "▸ Crew", "Activate" that pass through the full pipeline only to produce the same text they started with.INLINE_ELEMENTSset andinlineoption tomarkdownToHtmlto disable block-level markdown constructs (lists, headings, blockquotes) inside inline HTML elements like<span>.{for}loops.Detection
Conservative regex
/[*_#|~[>\-+=]|![|\d+./covers all CommonMark + GFM syntax characters. Any false positive (text contains-` but not as a list item) harmlessly falls through to the existing micromark path. Zero risk to markdown rendering.Test plan
<p>wrapping)tsc --noEmitcleanCloses #145
🤖 Generated with Claude Code