COO-1515: cluster/component healh backend & resources update#976
COO-1515: cluster/component healh backend & resources update#976openshift-merge-bot[bot] merged 1 commit intorhobs:mainfrom
Conversation
|
@jgbernalp please take a look 🙏 |
tremes
changed the title
|
@tremes: This pull request references COO-1515 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tremes
force-pushed
the
uiplugin-extend
branch
from
826ed7e to
b637a59
Compare
tremes
force-pushed
the
uiplugin-extend
branch
from
b637a59 to
7be2ec7
Compare
|
LGTM |
tremes
force-pushed
the
uiplugin-extend
branch
from
7be2ec7 to
45d2a84
Compare
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
My initial understanding was that the incidents and clusterHealthAnalyzer were equivalent hence I'm not sure to get why we deploy additional resources when clusterHealthAnalyzer is enabled.
|
Not directly to this PR but it looks like we don't have any end-to-end tests for the health analyzer (even something as simple as adding the plugin with the feature being enabled and testing that the resource is successfully reconciled)? |
@simonpasquier They were the same, but we want to enable this new feature (cluster/component health) in the cluster-health-analyzer and therefore these updates.
👍 I will create a task for this. |
I suppose that it's more about me not understanding the scope of the work. Let's chat tomorrow morning. |
tremes
force-pushed
the
uiplugin-extend
branch
from
45d2a84 to
f735981
Compare
tremes
force-pushed
the
uiplugin-extend
branch
from
f735981 to
ce95d31
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
This enables new feature "component health" evaluation in the cluster-health-analyzer. The feature is tracked in OBSDA-1293. The main additions here are: