COO-1515: add the cluster-health-analyzer feature

[tremes]

This is adding a new cluster-health-analyzer feature so that the incident page is still displayed when this feature is enabled. It's related to the rhobs/observability-operator#976

[openshift-ci-robot]

@tremes: This pull request references COO-1515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is adding a new cluster-health-analyzer feature so that the incident page is still displayed when this feature is enabled. It's related to the rhobs/observability-operator#976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jgbernalp]

This might create the problem that 2 incidents tabs are added if incidents and health analyzer are both active. I think a better approach would be to keep the config/cluster-health-analyzer.patch.json remove the old incidents patch, having a single patch. And add logic to the go server to apply the patch in the case incidents or health analyzer features are enabled. Something similar to what we did in the logging plugin: https://github.com/openshift/logging-view-plugin/blob/main/pkg/server/manifest_handler.go#L44

[jgbernalp]

/lgtm

[jgbernalp]

/test e2e-monitoring

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jgbernalp]

/label qe-approved
tested the extension injection for both features

[openshift-ci-robot]

@tremes: This pull request references COO-1515 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This is adding a new cluster-health-analyzer feature so that the incident page is still displayed when this feature is enabled. It's related to the rhobs/observability-operator#976

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgbernalp]

/cherry-pick release-coo-0.5

[openshift-cherrypick-robot]

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-0.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jgbernalp: new pull request created: #738

Details

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.