docs: reconcile Rename change-annotations (#70/#133) into canonical docs#142
Merged
clrudolphi merged 1 commit intoJul 13, 2026
Merged
Conversation
Folds the as-built Rename Change Annotations implementation back into LSP-IDE-Support-Feature-Designs.md (F16 as-built section), registers WorkspaceEditBuilder/RenameChangeAnnotations/RenamePostApplyCoordinator in Architecture.md, promotes RA-1 into the Open Questions register as Q23, and folds RA-2/RA-3/RA-4 into a new known-limitations subsection. Closes #134 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 12, 2026
clrudolphi
added a commit
that referenced
this pull request
Jul 13, 2026
Resolves the Q23/Q24 numbering collision: master (via #142) already landed RA-1 as Q23, so this branch's IH-3 row is renumbered to Q24 and kept after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LSP-IDE-Support-Feature-Designs.md: negotiation,WorkspaceEditBuilder/RenameChangeAnnotations, the VSworkspace/applyEditpush, closed-file cache invalidation, and where the as-built behavior deviates from the plan (NeedsConfirmationlogic).WorkspaceEditBuilder,RenameChangeAnnotations, andRenamePostApplyCoordinatorinLSP-IDE-Support-Architecture.md.RA-1(undo granularity) into the Open Questions register asQ23inLSP-IDE-Support-Open-Questions.md.RA-2/RA-3/RA-4into a new "Known limitations" subsection under the F16 as-built content, since each turned out to be moot or resolved differently than planned.Closes #134
Test plan
Features/Rename/*.cssource (WorkspaceEditBuilder,RenameChangeAnnotations,StepRenameHandler,RenamePostApplyCoordinator).🤖 Generated with Claude Code