[pull] master from kimden:master

.github/ISSUE_TEMPLATE/defect.yml

@@ -0,0 +1,89 @@
+name: Defect
+description: Report bugs, crashes, or unintended behavior
+labels: ['T: bug']
+
+body:
+
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: Provide a clear and concise explanation of the problem encountered.
+    validations:
+      required: true
+
+  - type: textarea
+    id: to_reproduce
+    attributes:
+      label: Steps to reproduce
+      description: Outline the exact sequence of actions required to reproduce the issue.
+      placeholder: |
+        1. Launch SuperTuxKart
+        2. Navigate to [specific menu/location]
+        3. Perform [specific action]
+        4. Observe unexpected behavior
+    validations:
+      required: true
+
+  - type: textarea
+    id: config
+    attributes:
+      label: Configuration
+      description: |
+        Include the following details to help us diagnose the issue:
+        - SuperTuxKart version (visible in the "About" menu)
+        - Installation source (official website, package manager, etc.)
+        - Operating system and version
+        - CPU/GPU specifications
+        - Controller/keyboard type (if relevant)
+      placeholder: |
+        SuperTuxKart version: 1.4
+        Installation source: Official repository
+        OS: Ubuntu 24.04
+        CPU: i5-10400
+        GPU: RX 580
+        Input device: USB keyboard
+    validations:
+      required: true
+
+  - type: textarea
+    id: error_msg
+    attributes:
+      label: Error message
+      description: |
+        If an error message was shown, please paste the complete error message, or a screenshot of it.
+      value: |
+        ```
+        [Paste error message here]
+        ```
+
+  - type: textarea
+    id: stdout
+    attributes:
+      label: Log File (stdout.log)
+      description: |
+        Attach the log file (stdout.log) from your latest session where the issue occurred.
+        File locations:
+        - Windows: %appdata%\supertuxkart\config-0.10\stdout.log
+        - macOS: ~/Library/Application Support/supertuxkart/config-0.10/stdout.log
+        - Linux and other Unix-based systems: 
+          $XDG_CONFIG_HOME/supertuxkart/config-0.10/stdout.log 
+          or ~/.config/supertuxkart/config-0.10/stdout.log
+      value: |
+        ```
+        [Paste contents of stdout.log here]
+        ```
+
+  - type: textarea
+    id: input
+    attributes:
+      label: Input Configuration (input.xml)
+      description: |
+        If your issue is related to the input config (gamepads, keyboards), 
+        please provide your file input.xml located in the same directory as stdout.log.
+      value: |
+        ```
+        [Paste contents of input.xml here]
+        ```
+
+

.github/ISSUE_TEMPLATE/enhancement.yml

@@ -0,0 +1,13 @@
+name: Enhancement
+description: Request for new features
+labels: ['T: Suggestion']
+
+body:
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: |
+        If applicable, add screenshots or mockups to help explain your request.
+    validations:
+      required: true

.github/workflows/apple.yml

@@ -29,12 +29,15 @@ jobs:
         uses: ASzc/change-string-case-action@v1
         with:
           string: ${{ matrix.platform }}
-      - name: Download cctools
+      - name: Download cctools and ISPC
         run: |
           cd /opt
-          wget https://github.com/supertuxkart/dependencies/releases/download/cctools/cctools-14.1.tar.xz
+          wget https://github.com/kimden/stk-dependencies/releases/download/cctools/cctools-14.1.tar.xz
           tar xf cctools-14.1.tar.xz
           rm cctools-14.1.tar.xz
+          wget https://github.com/supertuxkart/dependencies/releases/download/preview/ispc-cross-1.26.0.tar.xz
+          tar xf ispc-cross-1.26.0.tar.xz
+          rm ispc-cross-1.26.0.tar.xz
       - name: Restore timestamps
         run: |
           wget https://github.com/MestreLion/git-tools/archive/refs/heads/main.zip
@@ -49,7 +52,7 @@ jobs:
             echo "cache_$number=apple-${{ github.ref }}-${{ matrix.arch }}-${{ matrix.platform }}-$id" >> $GITHUB_ENV
           done
       - name: Handle build cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: |
             build
@@ -66,7 +69,7 @@ jobs:
             ${{ env.cache_9 }}
       - name: Download dependencies
         run: |
-          wget https://github.com/supertuxkart/dependencies/releases/download/preview/dependencies-${{ steps.sysroot.outputs.lowercase }}.tar.xz
+          wget https://github.com/kimden/stk-dependencies/releases/download/preview/dependencies-${{ steps.sysroot.outputs.lowercase }}.tar.xz
           tar xf dependencies-${{ steps.sysroot.outputs.lowercase }}.tar.xz
       - name: Configure clang runtime name
         run: |
@@ -86,14 +89,15 @@ jobs:
           mkdir -p build
           cd build
           cmake .. -DCCTOOLS_PREFIX=/opt/cctools -DCCTOOLS_ARCH=${{ matrix.arch }} -DCCTOOLS_PLATFORM=${{ matrix.platform }} \
-          -DRT=/opt/cctools/darwin/libclang_rt.${{ env.rt }}.a -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-cctools.cmake -DCHECK_ASSETS=OFF
+          -DRT=/opt/cctools/darwin/libclang_rt.${{ env.rt }}.a -DCMAKE_TOOLCHAIN_FILE=../cmake/Toolchain-cctools.cmake -DCHECK_ASSETS=OFF \
+          -DBC7_ISPC=ON -DCMAKE_ISPC_COMPILER=/opt/ispc/bin/ispc
       - name: Build
         run: |
           cd build
           make -j4
           mv bin ../${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
       - name: Upload binaries
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
           path: ${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
@@ -113,7 +117,7 @@ jobs:
           echo "release_tag=`basename $GITHUB_REF`" >> $GITHUB_ENV
           echo "release_name=`basename $GITHUB_REF`" >> $GITHUB_ENV
       - name: Configure packaging name for non-releasing branch
-        if: ${{ (github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')) || github.repository_owner != 'supertuxkart' }}
+        if: ${{ (github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')) }}
         run: |
           echo "release_tag=" >> $GITHUB_ENV
           echo "release_name=" >> $GITHUB_ENV
@@ -131,27 +135,29 @@ jobs:
           echo "${{ env.release_name }}"
           echo "${{ env.release_pre }}"
       - name: Download binaries
-        uses: actions/download-artifact@v2
-      - name: Mask developer name
-        run: |
-          echo "::add-mask::${{ secrets.MAC_DEVELOPER_NAME }}"
-      - name: Import certificates
-        if: ${{ env.release_tag != '' }}
-        uses: apple-actions/import-codesign-certs@v1
-        with:
-          p12-file-base64: ${{ secrets.MAC_DEVELOPER_ID_P12_FILE }}
-          p12-password: ${{ secrets.MAC_DEVELOPER_ID_P12_PASSWORD }}
+        uses: actions/download-artifact@v4
+      #- name: Mask developer name
+      #  run: |
+      #    echo "::add-mask::${{ secrets.MAC_DEVELOPER_NAME }}"
+      #- name: Import certificates
+      #  if: ${{ env.release_tag != '' }}
+      #  uses: apple-actions/import-codesign-certs@v1
+      #  with:
+      #    p12-file-base64: ${{ secrets.MAC_DEVELOPER_ID_P12_FILE }}
+      #    p12-password: ${{ secrets.MAC_DEVELOPER_ID_P12_PASSWORD }}
       - name: Run dylibbundler and sign STK
         if: ${{ env.release_tag != '' }}
-        env:
-          developer_id: "Developer ID Application: ${{ secrets.MAC_DEVELOPER_NAME }} (${{ secrets.MAC_DEVELOPER_TEAM }})"
+      #  env:
+      #    developer_id: "Developer ID Application: ${{ secrets.MAC_DEVELOPER_NAME }} (${{ secrets.MAC_DEVELOPER_TEAM }})"
         run: |
-          wget https://github.com/supertuxkart/dependencies/releases/download/preview/dependencies-macosx.tar.xz
+          wget https://github.com/kimden/stk-dependencies/releases/download/preview/dependencies-macosx.tar.xz
           tar xf dependencies-macosx.tar.xz
           HOMEBREW_NO_AUTO_UPDATE=1 brew install dylibbundler
           lipo -create ./macosx-x86_64/supertuxkart.app/Contents/MacOS/supertuxkart ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -output ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart
           chmod 755 ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart
-          dylibbundler -od -b -x ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -d ./macosx-arm64/supertuxkart.app/Contents/libs/ -p @executable_path/../libs/ -s dependencies-macosx/lib -ns
+          install_name_tool -delete_rpath @loader_path/Frameworks ./dependencies-macosx/lib/libSDL2.dylib
+          install_name_tool -delete_rpath @executable_path/Frameworks ./dependencies-macosx/lib/libSDL2.dylib
+          dylibbundler -od -b -x ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -d ./macosx-arm64/supertuxkart.app/Contents/libs/ -p @executable_path/../libs/ -s ./dependencies-macosx/lib -ns
           # We use SDL_Vulkan_LoadLibrary for 10.9 compatibility, so otool -L supertuxkart has no libMoltenVK.dylib
           cp ./dependencies-macosx/lib/libMoltenVK.dylib ./macosx-arm64/supertuxkart.app/Contents/libs/
           cd ./macosx-arm64/supertuxkart.app/Contents/Resources/data
@@ -160,16 +166,19 @@ jobs:
           rm stk-assets-full.zip
           cd ../../../../..
           mv ./macosx-arm64/supertuxkart.app SuperTuxKart.app
-          codesign --force --sign "$developer_id" SuperTuxKart.app/Contents/libs/*.dylib
-          codesign --force --options=runtime --deep --sign "$developer_id" SuperTuxKart.app
-      - name: "Notarize release build"
-        if: ${{ env.release_tag != '' && github.ref != 'refs/heads/master' }}
-        run: |
-          ditto -c -k --sequesterRsrc --keepParent SuperTuxKart.app tmp.zip
-          xcrun notarytool submit tmp.zip --apple-id ${{ secrets.STK_NOTARIZATION_USERNAME }} \
-                                          --password ${{ secrets.STK_NOTARIZATION_PASSWORD }} \
-                                          --team-id ${{ secrets.MAC_DEVELOPER_TEAM }} --wait
-          xcrun stapler staple SuperTuxKart.app
+          # Use Ad Hoc certificate for now, previous certificate has been expired.
+          codesign --force -s - SuperTuxKart.app/Contents/libs/*.dylib
+          codesign --force --deep -s - SuperTuxKart.app
+          #codesign --force --sign "$developer_id" SuperTuxKart.app/Contents/libs/*.dylib
+          #codesign --force --options=runtime --deep --sign "$developer_id" SuperTuxKart.app
+      #- name: "Notarize release build"
+      #  if: ${{ env.release_tag != '' && github.ref != 'refs/heads/master' }}
+      #  run: |
+      #    ditto -c -k --sequesterRsrc --keepParent SuperTuxKart.app tmp.zip
+      #    xcrun notarytool submit tmp.zip --apple-id ${{ secrets.STK_NOTARIZATION_USERNAME }} \
+      #                                    --password ${{ secrets.STK_NOTARIZATION_PASSWORD }} \
+      #                                    --team-id ${{ secrets.MAC_DEVELOPER_TEAM }} --wait
+      #    xcrun stapler staple SuperTuxKart.app
       - name: Archive
         if: ${{ env.release_tag != '' }}
         run: |

.github/workflows/linux.yml

@@ -28,7 +28,7 @@ jobs:
       matrix:
         os: [ubuntu-latest]
         compiler: [gcc, clang]
-        build_type: [Debug, Release]
+        build_type: [Debug, RelWithDebInfo, Release]
         server_only: [ON, OFF]
         exclude:
           - os: macos-latest
@@ -56,8 +56,7 @@ jobs:
           echo "release_name=`basename $GITHUB_REF`" >> $GITHUB_ENV
       - name: Configure packaging name for non-releasing branch
         if: ${{ matrix.build_type != 'Release' || matrix.server_only != 'OFF' ||
-            !(github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/')) ||
-            github.repository_owner != 'supertuxkart' }}
+            !(github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/')) }}
         run: |
           echo "release_tag=" >> $GITHUB_ENV
           echo "release_name=" >> $GITHUB_ENV
@@ -137,7 +136,7 @@ jobs:
           $CXX --version
           mkdir "build"
           cd "build"
-          CFLAGS="-mmacosx-version-min=10.9" CXXFLAGS="-mmacosx-version-min=10.9" LINKFLAGS="-mmacosx-version-min=10.9" LDFLAGS="-mmacosx-version-min=10.9" /usr/local/opt/cmake/bin/cmake .. -DCMAKE_OSX_DEPLOYMENT_TARGET=10.9 -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSERVER_ONLY=$SERVER_ONLY -DCHECK_ASSETS=off -DBUILD_RECORDER=off;
+          CFLAGS="-mmacosx-version-min=10.13" CXXFLAGS="-mmacosx-version-min=10.13" LINKFLAGS="-mmacosx-version-min=10.13" LDFLAGS="-mmacosx-version-min=10.13" /usr/local/opt/cmake/bin/cmake .. -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DSERVER_ONLY=$SERVER_ONLY -DCHECK_ASSETS=off -DBUILD_RECORDER=off;
       - name: Build and install
         working-directory: build
         run: |

.github/workflows/switch.yml

@@ -45,7 +45,7 @@ jobs:
           echo "release_tag=`basename $GITHUB_REF`" >> $GITHUB_ENV
           echo "release_name=`basename $GITHUB_REF`" >> $GITHUB_ENV
       - name: Configure packaging name for non-releasing branch
-        if: ${{ (github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')) || github.repository_owner != 'supertuxkart' }}
+        if: ${{ (github.ref != 'refs/heads/master' && !startsWith(github.ref, 'refs/tags/')) }}
         run: |
           echo "release_tag=" >> $GITHUB_ENV
           echo "release_name=" >> $GITHUB_ENV
@@ -72,7 +72,7 @@ jobs:
             echo "cache_$number=switch-${{ github.ref }}-$id" >> $GITHUB_ENV
           done
       - name: Handle build cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           # This is unnecessarily verbose and might break, but again ! seems broken
           # See: https://github.com/Mstrodl/stk-code/runs/2333673736?check_suite_focus=true#step:16:34