Conversation
…and type fixes Co-authored-by: Cursor <cursoragent@cursor.com>
Summary of ChangesHello @Marcellolepoe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the main landing page for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and impressive redesign of the landing page and blog, incorporating a host of new components, animations, and content. The changes replace the previous structure with a more modern, visually engaging user experience, notably featuring complex animations to demonstrate search engine ranking improvements. My feedback is focused on enhancing the maintainability of these new additions by refactoring large components and abstracting hardcoded values.
| if (activeCategory !== "all") { | ||
| posts = posts.filter(post => | ||
| post.tags?.some(tag => | ||
| tag.toLowerCase().replace(/\s+/g, "-") === activeCategory || | ||
| tag.toLowerCase().includes(activeCategory.replace(/-/g, " ")) | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
The tag filtering logic combines a slug match with a substring match, which can be brittle. For example, a tag 'Advanced SEO Insights' would match the category 'SEO Insights', which might not be the intended behavior. A more robust approach is to rely on a single, consistent matching strategy. Normalizing the post tags to slugs and comparing them directly against the activeCategory ID would make the filtering more predictable and less error-prone.
if (activeCategory !== "all") {
posts = posts.filter(post =>
post.tags?.some(tag =>
tag.toLowerCase().replace(/\s+/g, "-") === activeCategory
)
);
}
| <div className="flex items-baseline justify-center gap-1"> | ||
| <span className="font-serif text-4xl text-neutral-900 sm:text-5xl dark:text-white">$99</span> | ||
| <span className="text-neutral-500 dark:text-neutral-400">/mo</span> | ||
| </div> | ||
| <div className="mt-2 flex flex-col items-center gap-1"> | ||
| <span className="text-lg text-neutral-400 line-through">$199/mo</span> | ||
| <span className="inline-block rounded-full bg-amber-400 px-4 py-1.5 font-bold text-amber-900 text-sm">50% OFF</span> | ||
| </div> |
There was a problem hiding this comment.
The prices $99 and $199 are hardcoded here. It's a good practice to extract such values, which are likely to change in the future, into constants defined at the top of the module. This makes them easier to manage and update, reducing the risk of errors during future price adjustments.
| <div className="flex items-baseline justify-center gap-1"> | |
| <span className="font-serif text-4xl text-neutral-900 sm:text-5xl dark:text-white">$99</span> | |
| <span className="text-neutral-500 dark:text-neutral-400">/mo</span> | |
| </div> | |
| <div className="mt-2 flex flex-col items-center gap-1"> | |
| <span className="text-lg text-neutral-400 line-through">$199/mo</span> | |
| <span className="inline-block rounded-full bg-amber-400 px-4 py-1.5 font-bold text-amber-900 text-sm">50% OFF</span> | |
| </div> | |
| <div className="flex items-baseline justify-center gap-1"> | |
| <span className="font-serif text-4xl text-neutral-900 sm:text-5xl dark:text-white">${SALE_PRICE}</span> | |
| <span className="text-neutral-500 dark:text-neutral-400">/mo</span> | |
| </div> | |
| <div className="mt-2 flex flex-col items-center gap-1"> | |
| <span className="text-lg text-neutral-400 line-through">${REGULAR_PRICE}/mo</span> | |
| <span className="inline-block rounded-full bg-amber-400 px-4 py-1.5 font-bold text-amber-900 text-sm">50% OFF</span> | |
| </div> |
| function App() { | ||
| return ( | ||
| <main className="bg-background"> | ||
| <FounderHero /> | ||
| <FounderWhatItIs /> | ||
| <FounderTransparency /> | ||
| <FounderStrategist /> | ||
| <FounderGrowth /> | ||
| <FounderIntervention /> | ||
| <FounderCTA /> | ||
| <main className="relative"> | ||
| <LiquidGradientBackground /> | ||
| <SerpClimbDemo /> | ||
| <SocialProofSection /> | ||
| <JourneySection /> | ||
| <ResultsSection /> | ||
| <FeaturesSection /> | ||
| <PricingSection /> | ||
| <CTASection /> | ||
| </main> | ||
| ); | ||
| } |
There was a problem hiding this comment.
This file is over 900 lines long and defines multiple large, distinct components for the landing page sections. To improve maintainability, readability, and reusability, it's highly recommended to extract each section component (SocialProofSection, JourneySection, ResultsSection, FeaturesSection, PricingSection, CTASection) into its own file. These can be organized under a common directory like apps/seo-www/src/routes/-components/landing/.
|
Cloudflare Preview URL for WWW 🎈 : https://pr-400.rectangularlabs.com (custom domain) |
1 participant
…and type fixes