Skip to content

Quality: Bitmap cache uses non-thread-safe HashMap from potentially concurrent callers #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire-light42 merged 1 commit into from
Mar 30, 2026
+5 −4
Merged

Quality: Bitmap cache uses non-thread-safe HashMap from potentially concurrent callers #2585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/src/main/java/com/lagradost/cloudstream3/utils/downloader/DownloadUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@ import com.lagradost.cloudstream3.utils.downloader.DownloadFileManagement.getFol
import com.lagradost.cloudstream3.utils.txt
import kotlinx.coroutines.Job
import kotlinx.coroutines.runBlocking
import java.util.concurrent.ConcurrentHashMap

/** Separate object with helper functions for the downloader */
object DownloadUtils {
private val cachedBitmaps = hashMapOf<String, Bitmap>()
private val cachedBitmaps = ConcurrentHashMap<String, Bitmap>()
internal fun Context.getImageBitmapFromUrl(
url: String,
headers: Map<String, String>? = null
): Bitmap? = safe {
if (cachedBitmaps.containsKey(url)) {
return@safe cachedBitmaps[url]
cachedBitmaps[url]?.let {
return@safe it
}

val imageLoader = SingletonImageLoader.get(this)
Expand All @@ -50,7 +51,7 @@ object DownloadUtils {
}

bitmap?.let {
cachedBitmaps[url] = it
cachedBitmaps.putIfAbsent(url, it)
}

return@safe bitmap
Expand Down