Quality: Bitmap cache uses non-thread-safe HashMap from potentially concurrent callers

[Nam0101]

Problem

cachedBitmaps is a global mutable HashMap accessed without synchronization in getImageBitmapFromUrl. This utility is likely called from multiple coroutine/background contexts. Concurrent read/write on HashMap is unsafe and can lead to race conditions, stale reads, or map corruption/crashes under load.

Severity: medium
File: app/src/main/java/com/lagradost/cloudstream3/utils/downloader/DownloadUtils.kt

Solution

Replace with a thread-safe map and atomic put: private val cachedBitmaps = ConcurrentHashMap<String, Bitmap>() Then use: cachedBitmaps[cacheKey]?.let { return@safe it } ... bitmap?.let { cachedBitmaps.putIfAbsent(cacheKey, it) }

Changes

• app/src/main/java/com/lagradost/cloudstream3/utils/downloader/DownloadUtils.kt (modified)

AI usage

This pull request was partially AI-assisted. AI was used to help with code drafting, refactoring suggestions, and PR text.

Testing

I personally reviewed all generated suggestions, verified the logic, and tested the final implementation before opening this PR.

• Existing tests pass
• Manual review completed
• No new warnings/errors introduced

[fire-light42]

Remember to mark your pull requests as AI assisted as per our AI Policy if you used AI for anything in the pull request.

[Nam0101]

Thanks for the reminder. I used AI assistance for parts of this PR, and I’ll update the PR description to disclose that accordingly.

[fire-light42]

Thank you for your contribution 👍