Skip to content

Quality: Subtitle deletion matches on substring extension, can delete non-subtitle files #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fire-light42 merged 2 commits into from
Mar 29, 2026
+2 −2
Merged

Quality: Subtitle deletion matches on substring extension, can delete non-subtitle files #2584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b71ae6
refactor: subtitle deletion matches on substring extension, can delet…
Nam0101 Mar 29, 2026
59f6a7d
Update SubtitleUtils.kt
fire-light42 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/com/lagradost/cloudstream3/utils/SubtitleUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ object SubtitleUtils {
cleanDisplay: String
): Boolean {
// Check if the file has a valid subtitle extension
val hasValidExtension = allowedExtensions.any { name.contains(it, ignoreCase = true) }
val hasValidExtension = allowedExtensions.any { name.endsWith(it, ignoreCase = true) }

// We can't have the exact same file as a subtitle
val isNotDisplayName = !name.equals(display, ignoreCase = true)
Expand All @@ -57,4 +57,4 @@ object SubtitleUtils {
fun cleanDisplayName(name: String): String {
return name.substringBeforeLast('.').trim()
}
}
}