Quality: Subtitle deletion matches on substring extension, can delete non-subtitle files#2584
Merged
fire-light42 merged 2 commits intorecloudstream:masterfrom Mar 29, 2026
Conversation
…e non-subtitle files `isMatchingSubtitle` checks extensions with `name.contains(...)` instead of checking the actual file suffix. This can classify non-subtitle files as subtitles (e.g. `movie.srt.mp4` contains `.srt`) and delete them in `deleteMatchingSubtitles`, causing real data loss. Affected files: SubtitleUtils.kt Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
Collaborator
|
Nice catch! I doubt it has accidentally deleted anything, but it is a very unnecessary risk. Remember to mark your pull requests as AI assisted as per our AI Policy if you used AI for anything in the pull request. |
Nam0101
deleted the
contribai/improve/quality/subtitle-deletion-matches-on-substring-e
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isMatchingSubtitlechecks extensions withname.contains(...)instead of checking the actual file suffix. This can classify non-subtitle files as subtitles (e.g.movie.srt.mp4contains.srt) and delete them indeleteMatchingSubtitles, causing real data loss.Severity:
highFile:
app/src/main/java/com/lagradost/cloudstream3/utils/SubtitleUtils.ktSolution
Match only by true file extension. Replace the extension check with
endsWithon a normalized filename:val lower = name.lowercase()val hasValidExtension = allowedExtensions.any { lower.endsWith(it) }Keep deletion gated on this stricter check.Changes
app/src/main/java/com/lagradost/cloudstream3/utils/SubtitleUtils.kt(modified)Testing