Skip to content

fix: allow Readium CLI to fetch files with spaces in name by resolving url for archivefetcher rather than straight .String()ing it #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chocolatkey merged 3 commits into from
Feb 27, 2026
Merged

fix: allow Readium CLI to fetch files with spaces in name by resolving url for archivefetcher rather than straight .String()ing it #286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64336c2
fix: resolve url for archivefetcher rather than straight .String()ing it
tefkah Jan 29, 2026
f0413e8
Merge branch 'develop' into tfk/fix-url
chocolatkey Feb 3, 2026
a1825c4
fix: implement suggestions
tefkah Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/fetcher/fetcher_archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,14 @@ func (f *ArchiveFetcher) Links(ctx context.Context) (manifest.LinkList, error) {

// Get implements Fetcher
func (f *ArchiveFetcher) Get(ctx context.Context, link manifest.Link) Resource {
entry, err := f.archive.Entry(link.Href.String())
// use decoded path for archive entry lookup to support files with spaces and special characters
var entryPath string
if hrefURL := link.Href.Resolve(nil, nil); hrefURL != nil {
entryPath = hrefURL.Path()
} else {
entryPath = link.Href.String()
}
entry, err := f.archive.Entry(entryPath)
if err != nil {
return NewFailureResource(link, NotFound(err))
}
Expand Down