RDKB-64347: Fixing coverity issues

[bharathivelp]

Reason for change: Fixing high medium priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
 
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com

[Copilot]

Pull request overview

This PR addresses high/medium Coverity findings primarily by replacing unbounded string operations (strcpy, sprintf, %s in sscanf) with bounded alternatives and adding a small guard against unsigned underflow in a log message.

Changes:

• Replace multiple strcpy/sprintf uses with snprintf (and one strcpy with strncpy + explicit NUL termination).
• Add field-width limits to sscanf to prevent buffer overreads/writes.
• Prevent index - 1 underflow in station connection-status logging.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
source/stats/wifi_monitor.c	Use snprintf instead of strcpy when updating RADIUS connected endpoint (non-PHASE2).
source/sampleapps/webconfig_consumer_apis.c	Clamp (index - 1) in log output to avoid underflow when index == 0.
source/dml/tr_181/sbapi/cosa_wifi_apis.c	Replace strcat/strcpy with bounded concatenation/copy for security-mode string building.
source/db/wifi_db_apis.c	Bound copy of last reboot reason from PSM to a fixed maximum length with explicit terminator.
source/core/wifi_mgr.c	Replace strcpy/sprintf with snprintf when populating VAP name and DB path.
source/core/wifi_ctrl_rbus_handlers.c	Add %63s limit to sscanf for extension parsing.
source/core/wifi_ctrl.c	Replace strcpy with snprintf when copying STA SSID out of the config map.
lib/pktgen/pktgen.c	Add %31s limit to sscanf for run_if parsing.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

getSecurityStringFromInt() now takes bufSize, but it still uses unbounded strlen(securityName). If securityName is not guaranteed to be NUL-terminated within bufSize, this can read past the provided buffer, and can also make bufSize - len incorrect. Use a bounded length calculation (e.g., strnlen(securityName, bufSize)) and guard len < bufSize before appending so the function is safe for all callers.

[Copilot]

This function hard-codes a 32-byte destination (strncpy(..., 31) + last_reboot_reason[31] = '\0'), but the API only accepts char *last_reboot_reason with no size. That creates an implicit contract that callers must always provide at least 32 bytes. Consider changing the signature to accept a buffer length (and using it), or at least using a named constant for the required size and documenting/enforcing it.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

index is declared as unsigned int, but it is populated via sscanf(event->name, "...%d...", &index) earlier in this function. Passing an unsigned int* for a %d conversion is undefined behavior and can also leave index at 0 if parsing fails. Consider switching the parse to an unsigned/signed conversion that matches the variable type, checking sscanf’s return value, and treating index == 0/parse failure as an invalid event name rather than silently logging radio 0 via the new ternary.

[Copilot]

Parsing STA properties with %u into an unsigned int is fine, but note that %u will accept a leading '-' and convert it to a very large unsigned value (e.g., "-1" -> UINT_MAX). If you want negative indexes to be treated as invalid input (not just "index > getNumberRadios"), parse into a signed temporary and validate > 0 before casting. Also, the later error log uses %d for index even though it’s unsigned; the format specifier should match the variable type to avoid undefined behavior / misleading logs.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.