RDKB-64347: Fixing coverity issues

Reason for change: Fixing high medium priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.
 
Risks: Low
Priority: P1
Signed-off-by: Velpula_Bharathi@comcast.com

Author: bharathivelp

lib/pktgen/pktgen.c

@@ -109,7 +109,7 @@ int onewifi_pktgen_is_running(void)
 
     if (fgets(str, BUF_LEN_MAX, fp) != NULL)
     {
-        if (sscanf(str, "Running: %s", run_if) == 1)
+        if (sscanf(str, "Running: %31s", run_if) == 1)
         {
             LOGD("%s: Packetgen is already running on interface [%s].", __func__, run_if);
             retval = 1;

source/core/wifi_ctrl.c

@@ -2950,7 +2950,7 @@ int get_sta_ssid_from_radio_config_by_radio_index(unsigned int radio_index, ssid
         if (map->vap_array[i].vap_index == index) {
             found = true;
             wifi_util_error_print(WIFI_CTRL,"[%s %d] ssid name : %s\n", __func__, __LINE__, get_vap_ssid(&map->vap_array[i]));
-            strcpy(ssid, get_vap_ssid(&map->vap_array[i]));
+            snprintf(ssid, sizeof(ssid_t), "%s", get_vap_ssid(&map->vap_array[i]));
             break;
         }
     }

source/core/wifi_ctrl_rbus_handlers.c

@@ -2711,7 +2711,10 @@ bus_error_t get_sta_attribs(char *name, raw_data_t *p_data, bus_user_data_t *use
     }
     wifi_util_dbg_print(WIFI_CTRL, "%s bus property=%s\n", __FUNCTION__, name);
 
-    sscanf(name, "Device.WiFi.STA.%d.%s", &index, extension);
+     if (sscanf(name, "Device.WiFi.STA.%d.%63s", &index, extension) != 2 || index < 1) {
+        wifi_util_error_print(WIFI_CTRL, "%s Invalid property name format: %s\n", __FUNCTION__, name);
+        return bus_error_invalid_input;
+     }
     if (index > getNumberRadios()) {
         wifi_util_error_print(WIFI_CTRL, "%s Invalid index %d\n", __FUNCTION__, index);
         return bus_error_invalid_operation;

source/core/wifi_mgr.c

@@ -140,8 +140,8 @@ int init_global_radio_config(rdk_wifi_radio_t *radios_cfg, UINT radio_index)
             radios_cfg->vaps.rdk_vap_array[vap_array_index].vap_index = wifi_hal_cap_obj->wifi_prop.interface_map[i].index;
             radios_cfg->vaps.vap_map.vap_array[vap_array_index].vap_index = wifi_hal_cap_obj->wifi_prop.interface_map[i].index;
             radios_cfg->vaps.vap_map.vap_array[vap_array_index].radio_index = radio_index;
-            strcpy((char *)radios_cfg->vaps.rdk_vap_array[vap_array_index].vap_name, (char *)wifi_hal_cap_obj->wifi_prop.interface_map[i].vap_name);
-            strcpy((char *)radios_cfg->vaps.vap_map.vap_array[vap_array_index].vap_name, (char *)wifi_hal_cap_obj->wifi_prop.interface_map[i].vap_name);
+            snprintf((char *)radios_cfg->vaps.rdk_vap_array[vap_array_index].vap_name, sizeof(radios_cfg->vaps.rdk_vap_array[vap_array_index].vap_name), "%s", wifi_hal_cap_obj->wifi_prop.interface_map[i].vap_name);
+            snprintf((char *)radios_cfg->vaps.vap_map.vap_array[vap_array_index].vap_name, sizeof(radios_cfg->vaps.vap_map.vap_array[vap_array_index].vap_name), "%s", wifi_hal_cap_obj->wifi_prop.interface_map[i].vap_name);
 
             // allocate mutex on heap since rdk_vap_array can be copied
             associated_devices_lock = malloc(sizeof(pthread_mutex_t));
@@ -286,7 +286,7 @@ int init_wifimgr()
     get_wifidml_obj()->desc.set_dml_init_status_fn(false);
 #endif
 
-    sprintf(db_file, "%s/rdkb-wifi.db", WIFIDB_DIR);
+    snprintf(db_file, sizeof(db_file), "%s/rdkb-wifi.db", WIFIDB_DIR);
     if (stat(db_file, &sb) != 0) {
         wifi_util_info_print(WIFI_MGR,"WiFiDB file not present FRcase\n");
         g_wifi_mgr.ctrl.factory_reset = true;

source/db/wifi_db_apis.c

@@ -9759,7 +9759,8 @@ int get_wifi_last_reboot_reason_psm_value(char *last_reboot_reason)
     memset(strValue, 0, sizeof(strValue));
     str = p_ccsp_desc->psm_get_value_fn(LAST_REBOOT_REASON_NAMESPACE, strValue, sizeof(strValue));
     if (str != NULL) {
-        strcpy(last_reboot_reason, str);
+        strncpy(last_reboot_reason, str, 31);
+        last_reboot_reason[31] = '\0';
         wifi_util_dbg_print(WIFI_MGR,"str is %s and last_reboot_reason is %s\n", str, last_reboot_reason);
     } else {
         wifi_util_error_print(WIFI_MGR,"%s:%d last_reboot_reason:%s \r\n", __func__, __LINE__, last_reboot_reason);

source/dml/tr_181/ml/cosa_wifi_dml.c

@@ -8650,7 +8650,7 @@ Security_GetParamStringValue
         /* collect value */
         char buf[32] = {0};
         if ( AnscSizeOfString(buf) < *pUlSize) {
-            getSecurityStringFromInt(pcfg->mode, buf);
+            getSecurityStringFromInt(pcfg->mode, buf, sizeof(buf));
             AnscCopyString(pValue, buf);
         } else {
             *pUlSize = AnscSizeOfString(buf) + 1;

source/dml/tr_181/sbapi/cosa_wifi_apis.c

@@ -432,21 +432,28 @@ INT getTxDataRateFromInt(wifi_bitrate_t DataTxRate, char *DataTxRateStr)
     return 0;
 }
 
-INT getSecurityStringFromInt(wifi_security_modes_t securityType, char *securityName)
+INT getSecurityStringFromInt(wifi_security_modes_t securityType, char *securityName, size_t bufSize)
 {
     unsigned int i;
+    size_t len;
+
+    if (securityName == NULL || bufSize == 0) {
+        CcspWifiTrace(("RDK_LOG_ERROR, %s Invalid input parameters\n", __func__));
+        return 0;
+    }
+    
     for (i = 0 ; i < ARRAY_SZ(wifiSecMap) ; ++i)
     {
         if(securityType == wifiSecMap[i].halSecCfgMethod)
         {
-            if (AnscSizeOfString(securityName) != 0)
+            len = strlen(securityName);
+            if (len > 0)
             {
-                strcat(securityName, ",");
-                strcat(securityName, wifiSecMap[i].wifiSecType);
+                snprintf(securityName + len, bufSize - len, ",%s", wifiSecMap[i].wifiSecType);
             }
             else
             {
-                strcpy(securityName, wifiSecMap[i].wifiSecType);
+                snprintf(securityName, bufSize, "%s", wifiSecMap[i].wifiSecType);
             }
        }
     }

source/sampleapps/webconfig_consumer_apis.c

@@ -2459,15 +2459,15 @@ void webconfig_consumer_sta_conn_status(rbusHandle_t handle, rbusEvent_t const*
     conn_status = (sta_conn_info.connect_status == wifi_connection_status_connected) ? true:false;
     if (conn_status == true) {
         printf("%s:%d: Station successfully connected with external AP radio:%d\r\n",
-                    __func__, __LINE__, index - 1);
+                    __func__, __LINE__, (index > 0) ? (index - 1) : 0);
         if (index == 1) {
             get_rbus_sta_interface_name(WIFI_STA_2G_INTERFACE_NAME);
         } else if (index == 2) {
             get_rbus_sta_interface_name(WIFI_STA_5G_INTERFACE_NAME);
         }
     } else {
         printf("%s:%d: Station disconnected with external AP:%d radio:%d\r\n",
-                __func__, __LINE__, conn_status, index - 1);
+                __func__, __LINE__, conn_status, (index > 0) ? (index - 1) : 0);
     }
     printf("%s:%d: MAC address info:%s\r\n", __func__, __LINE__, to_mac_str(sta_conn_info.bssid, mac_str));
 

source/stats/wifi_monitor.c

@@ -3466,14 +3466,14 @@ void notify_radius_endpoint_change(radius_fallback_and_failover_data_t *radius_d
         if (vapSecurity != NULL) {
             if(radius_data->radius_switch_reason == RADIUS_FAILOVER){
 #ifndef WIFI_HAL_VERSION_3_PHASE2
-                strcpy((char*)vapSecurity->u.radius.connectedendpoint,(char*)vapSecurity->u.radius.s_ip);
+                snprintf((char*)vapSecurity->u.radius.connectedendpoint, sizeof(vapSecurity->u.radius.connectedendpoint), "%s", (char*)vapSecurity->u.radius.s_ip);
 #else
                 vapSecurity->u.radius.connectedendpoint = vapSecurity->u.radius.s_ip;
 #endif
             }
             else {
 #ifndef WIFI_HAL_VERSION_3_PHASE2 
-                strcpy((char*)vapSecurity->u.radius.connectedendpoint,(char*)vapSecurity->u.radius.ip);
+                snprintf((char*)vapSecurity->u.radius.connectedendpoint, sizeof(vapSecurity->u.radius.connectedendpoint), "%s", (char*)vapSecurity->u.radius.ip);
 #else
                 vapSecurity->u.radius.connectedendpoint = vapSecurity->u.radius.ip;
 #endif