Skip to content

[core] fix test_placement_group_3_client_mode by changing url parser #61506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MengjinYan merged 2 commits into from
Mar 11, 2026
Merged

[core] fix test_placement_group_3_client_mode by changing url parser #61506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7b113b
[core] fix test_placement_group_3_client_mode by changing url parser
ZacAttack Mar 5, 2026
094cdb4
Merge branch 'master' into fix-test_placement_group_3_client_mode
ZacAttack Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/ray/dashboard/modules/event/event_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import time
from concurrent.futures import ThreadPoolExecutor
from typing import Union
from urllib.parse import urlparse

import ray._private.ray_constants as ray_constants
import ray.dashboard.consts as dashboard_consts
Expand Down Expand Up @@ -68,7 +67,7 @@ async def _get_dashboard_http_address(self):
if not dashboard_http_address:
raise ValueError("Dashboard http address not found in InternalKV.")
address = dashboard_http_address.decode()
if not urlparse(address).scheme:
if not address.startswith(("http://", "https://")):
address = f"http://{address}"
self._dashboard_http_address = address
return self._dashboard_http_address
Expand Down