[Docs] Add distributable manylinux wheel build path to development.rst#61504
Conversation
|
8b479ba to
7c2c92e
Compare
38bb1a0 to
098105c
Compare
There was a problem hiding this comment.
Code Review
This pull request adds a new development path to the documentation for building distributable manylinux wheels. The changes are clear and well-structured, introducing a new section with setup instructions and usage examples for the build-wheel.sh script. I have one suggestion to improve the clarity of a code comment to avoid potential confusion for users on different operating systems.
|
|
||
| .. code-block:: bash | ||
|
|
||
| # Build a wheel for the current platform: |
There was a problem hiding this comment.
The comment # Build a wheel for the current platform: could be misleading. The main text clarifies that the output is always a manylinux wheel, regardless of the host OS (e.g., macOS). A user on macOS might interpret "current platform" as "macOS" and expect a macOS wheel, but they will get a Linux wheel. To avoid this confusion, I suggest clarifying that the build targets manylinux but uses the host's architecture.
| # Build a wheel for the current platform: | |
| # Build a manylinux wheel for the host architecture: |
098105c to
f075c8b
Compare
7c2c92e to
15b6ed3
Compare
f075c8b to
d5e2a89
Compare
15b6ed3 to
0abe1e0
Compare
| - **Full source build (C++ + dashboard + editable install)** - make C++ changes or build all of Ray (see :ref:`full-source-build`). | ||
| - **Build Ray with C++** - choose one: | ||
|
|
||
| - **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` for installation on a cluster, testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`). |
There was a problem hiding this comment.
| - **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` for installation on a cluster, testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`). | |
| - **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` file for installation on a cluster, for testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`). |
There was a problem hiding this comment.
Solid, updating this!
0abe1e0 to
a9698fe
Compare
8b7de7e to
b0fae58
Compare
a9698fe to
2bb0a83
Compare
b0fae58 to
5fe28a3
Compare
99a4c5e to
3d9ba2f
Compare
5fe28a3 to
3e42afe
Compare
aslonnie
left a comment
There was a problem hiding this comment.
please ping me again when it is ready to merge
Add a third development path under a new "Build Ray with C++" nested list in the path-chooser, and a new "Building distributable manylinux wheels" section documenting build-wheel.sh. Cross-link from the full source build section. Topic: add-distributable-wheel Relative: reduce-callouts Signed-off-by: andrew <andrew@anyscale.com>
3e42afe to
c1b3c38
Compare
3d9ba2f to
34f3e08
Compare
Add a third development path under a new "Build Ray with C++" nested list in the path-chooser, and a new "Building distributable manylinux wheels" section documenting build-wheel.sh. Cross-link from the full source build section.
Topic: add-distributable-wheel
Relative: reduce-callouts
Signed-off-by: andrew andrew@anyscale.com