Skip to content

[Docs] Add distributable manylinux wheel build path to development.rst#61504

Open
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/reduce-calloutsfrom
andrew/revup/master/add-distributable-wheel
Open

[Docs] Add distributable manylinux wheel build path to development.rst#61504
andrew-anyscale wants to merge 1 commit intoandrew/revup/master/reduce-calloutsfrom
andrew/revup/master/add-distributable-wheel

Conversation

@andrew-anyscale
Copy link
Contributor

Add a third development path under a new "Build Ray with C++" nested list in the path-chooser, and a new "Building distributable manylinux wheels" section documenting build-wheel.sh. Cross-link from the full source build section.

Topic: add-distributable-wheel
Relative: reduce-callouts
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 4, 2026

Reviews in this chain:
#61503 [Docs] Reduce callout noise in development.rst
 └#61504 [Docs] Add distributable manylinux wheel build path to development.rst

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 4, 2026

# head base diff date summary
0 38bb1a05 8b479ba5 diff Mar 4 15:00 PM 1 file changed, 38 insertions(+), 1 deletion(-)
1 098105cc 7c2c92ef rebase Mar 4 15:03 PM 0 files changed
2 f075c8b0 15b6ed37 rebase Mar 4 15:08 PM 0 files changed
3 d5e2a89c 0abe1e04 diff Mar 4 15:19 PM 1 file changed, 4 insertions(+), 4 deletions(-)
4 8b7de7e3 a9698feb diff Mar 5 9:31 AM 1 file changed, 1 insertion(+), 1 deletion(-)
5 b0fae58c 2bb0a83e rebase Mar 5 9:34 AM 0 files changed
6 5fe28a3a 99a4c5ea rebase Mar 5 17:00 PM 0 files changed
7 3e42afe8 3d9ba2f2 rebase Mar 5 21:20 PM 0 files changed
8 c1b3c387 34f3e087 rebase Mar 6 12:18 PM 0 files changed

@andrew-anyscale andrew-anyscale added the docs An issue or change related to documentation label Mar 4, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from 8b479ba to 7c2c92e Compare March 4, 2026 23:03
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from 38bb1a0 to 098105c Compare March 4, 2026 23:03
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new development path to the documentation for building distributable manylinux wheels. The changes are clear and well-structured, introducing a new section with setup instructions and usage examples for the build-wheel.sh script. I have one suggestion to improve the clarity of a code comment to avoid potential confusion for users on different operating systems.


.. code-block:: bash

# Build a wheel for the current platform:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment # Build a wheel for the current platform: could be misleading. The main text clarifies that the output is always a manylinux wheel, regardless of the host OS (e.g., macOS). A user on macOS might interpret "current platform" as "macOS" and expect a macOS wheel, but they will get a Linux wheel. To avoid this confusion, I suggest clarifying that the build targets manylinux but uses the host's architecture.

Suggested change
# Build a wheel for the current platform:
# Build a manylinux wheel for the host architecture:

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from 098105c to f075c8b Compare March 4, 2026 23:08
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from 7c2c92e to 15b6ed3 Compare March 4, 2026 23:08
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from f075c8b to d5e2a89 Compare March 4, 2026 23:19
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from 15b6ed3 to 0abe1e0 Compare March 4, 2026 23:19
Copy link

@ronny-anyscale ronny-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

- **Full source build (C++ + dashboard + editable install)** - make C++ changes or build all of Ray (see :ref:`full-source-build`).
- **Build Ray with C++** - choose one:

- **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` for installation on a cluster, testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` for installation on a cluster, testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`).
- **Distributable manylinux wheel** - uses a manylinux build container to produce a ``.whl`` file for installation on a cluster, for testing the packaged artifact locally, or for sharing (see :ref:`build-distributable-wheel`).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, updating this!

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from 0abe1e0 to a9698fe Compare March 5, 2026 17:31
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch 2 times, most recently from 8b7de7e to b0fae58 Compare March 5, 2026 17:34
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from a9698fe to 2bb0a83 Compare March 5, 2026 17:34
@andrew-anyscale andrew-anyscale requested a review from aslonnie March 5, 2026 19:14
@andrew-anyscale andrew-anyscale added the go add ONLY when ready to merge, run all tests label Mar 5, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from b0fae58 to 5fe28a3 Compare March 6, 2026 01:01
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch 2 times, most recently from 99a4c5e to 3d9ba2f Compare March 6, 2026 05:20
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from 5fe28a3 to 3e42afe Compare March 6, 2026 05:20
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ping me again when it is ready to merge

Add a third development path under a new "Build Ray with C++" nested list in the path-chooser, and a new "Building distributable manylinux wheels" section documenting build-wheel.sh. Cross-link from the full source build section.

Topic: add-distributable-wheel
Relative: reduce-callouts
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-distributable-wheel branch from 3e42afe to c1b3c38 Compare March 6, 2026 20:18
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/reduce-callouts branch from 3d9ba2f to 34f3e08 Compare March 6, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants