Skip to content

[Docs] Add path-chooser, fix cross-references, and reorganize tips#61501

Merged
aslonnie merged 3 commits intomasterfrom
andrew/revup/master/add-refs
Mar 6, 2026
Merged

[Docs] Add path-chooser, fix cross-references, and reorganize tips#61501
aslonnie merged 3 commits intomasterfrom
andrew/revup/master/add-refs

Conversation

@andrew-anyscale
Copy link
Contributor

  • Remove combined opening tip (Python-only and Full build hints)
  • Add path-chooser list at the top to direct readers to Python-only or
    full source build paths
  • Replace "as explained/described above" prose with :ref: cross-references
    to fork-ray-repo and prepare-venv labels
  • Move "if you already followed python-develop..." hint into a tip inside
    the Full Source Build section

Topic: add-refs
Relative: update-wheel-docs
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale andrew-anyscale requested a review from a team as a code owner March 4, 2026 23:00
@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 4, 2026

Reviews in this chain:
#61501 [Docs] Add path-chooser, fix cross-references, and reorganize tips
 └#61502 [Docs] Apply Google style guide to development.rst
  └#61503 [Docs] Reduce callout noise in development.rst
   └#61504 [Docs] Add distributable manylinux wheel build path to development.rst

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Mar 4, 2026

# head base diff date summary
0 7a39e957 ec5b126b diff Mar 4 15:00 PM 1 file changed, 12 insertions(+), 8 deletions(-)
1 2b82c0b0 06399c7c rebase Mar 4 15:03 PM 0 files changed
2 9e5f42c8 bd2a7496 rebase Mar 4 15:08 PM 0 files changed
3 7a51cf6e bd2a7496 diff Mar 4 15:19 PM 1 file changed, 5 insertions(+), 3 deletions(-)
4 87b91a3d c7afebfd diff Mar 5 21:20 PM 0 files changed

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the development setup documentation by reorganizing content, adding a 'path-chooser' list for different build types, and replacing vague phrases with specific cross-references. My review identifies a minor inconsistency in the cross-referencing style and a point of ambiguity in a new tip that could be clarified to prevent user error.

@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-refs branch from 7a39e95 to 2b82c0b Compare March 4, 2026 23:03
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/update-wheel-docs branch 2 times, most recently from 06399c7 to bd2a749 Compare March 4, 2026 23:08
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-refs branch 2 times, most recently from 9e5f42c to 7a51cf6 Compare March 4, 2026 23:19
Copy link

@ronny-anyscale ronny-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-anyscale andrew-anyscale requested a review from aslonnie March 5, 2026 19:14
@andrew-anyscale andrew-anyscale added the go add ONLY when ready to merge, run all tests label Mar 5, 2026
Base automatically changed from andrew/revup/master/update-wheel-docs to master March 6, 2026 04:09
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has conflicts?

- Remove combined opening tip (Python-only and Full build hints)
- Add path-chooser list at the top to direct readers to Python-only or
  full source build paths
- Replace "as explained/described above" prose with :ref: cross-references
  to fork-ray-repo and prepare-venv labels
- Move "if you already followed python-develop..." hint into a tip inside
  the Full Source Build section

Topic: add-refs
Relative: update-wheel-docs
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/add-refs branch from 7a51cf6 to 87b91a3 Compare March 6, 2026 05:20
@andrew-anyscale
Copy link
Contributor Author

Conflicts resolved

andrew-anyscale and others added 2 commits March 6, 2026 11:31
Apply Google developer documentation style guide rules to
development.rst:

- Sentence case: fix 11 headings (Source, Steps, Only, Full Source
Build, MacOS, Development Tooling, Pre-commit Hooks, Advanced Build
Options, Fast/Debug/Optimized Builds, Building the Docs)
- Second person: replace "We provide" with "Use the script"
- Present tense: replace future "will" constructions throughout (env var
list, prose sections)
- Contractions: "Do not" -> "Don't", "will not" -> "won't", "pip is not"
-> "isn't"
- Active voice: env var list passive constructions converted ("will be
built" -> "Ray builds", etc.)
- macOS branding: fix "MacOS" -> "macOS" and "mac" -> "Mac" throughout

Signed-off-by: andrew <andrew@anyscale.com>
@aslonnie aslonnie merged commit 1f3a82e into master Mar 6, 2026
3 of 6 checks passed
@aslonnie aslonnie deleted the andrew/revup/master/add-refs branch March 6, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs An issue or change related to documentation go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants