-
Notifications
You must be signed in to change notification settings - Fork 61
feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels
#165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8f256fe
feat(backend): add `CellSized` trait for querying cell dimensions in …
junkdog c31b275
add get_device_pixel_ratio and clean-up dead code
junkdog 0fc9970
reduce visiblity
junkdog 35564a3
Merge branch 'main' into cell-sized-trait-for-backends
junkdog 5e0a856
use beamterm's css cell size fn
junkdog 41aa278
move cell_sized to backend
junkdog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /// A type that knows the pixel dimensions of its terminal cells. | ||
| /// | ||
| /// # Physical vs. CSS pixels | ||
| /// | ||
| /// On HiDPI / Retina displays the device pixel ratio (DPR) causes one | ||
| /// CSS pixel to map to multiple physical (device) pixels. | ||
| /// | ||
| /// - **Physical pixels** (`cell_size_px`): the actual device pixels | ||
| /// occupied by a cell. Useful for pixel-perfect rendering and GPU work. | ||
| /// - **CSS pixels** (`cell_size_css_px`): the logical size as seen by | ||
| /// the browser layout engine. Useful for DOM positioning, mouse | ||
| /// coordinate translation, and canvas drawing. | ||
| pub trait CellSized { | ||
| /// Returns the size of a cell in physical (device) pixels as `(width, height)`. | ||
| fn cell_size_px(&self) -> (f32, f32); | ||
|
|
||
| /// Returns the size of a cell in CSS (logical) pixels as `(width, height)`. | ||
| fn cell_size_css_px(&self) -> (f32, f32); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should include this trait in either
utilmodule or move it underbackendThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll move it to backend! (util is an option too ofc, but it feels a bit wrong - maybe it's just me).