feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels#165
Open
junkdog wants to merge 5 commits intoratatui:mainfrom
Open
feat(backend): add CellSized trait for querying cell dimensions in physical and CSS pixels#165junkdog wants to merge 5 commits intoratatui:mainfrom
CellSized trait for querying cell dimensions in physical and CSS pixels#165junkdog wants to merge 5 commits intoratatui:mainfrom
Conversation
af75cf3 to
5a92e02
Compare
CellSized trait for querying cell dimensions in physical and CSS pixelsCellSized trait for querying cell dimensions in physical and CSS pixels
5a92e02 to
f553cba
Compare
…physical and CSS pixels
f553cba to
8f256fe
Compare
Member
Author
|
hmm, tested with the "minimal" example: the offset bug when zooming in the webgl2 backend has returned... it's unrelated to these changes, as it exhibits the same buggy behavior one main. i'll fix it separately (+ add some form of integration test...) |
Member
Author
fixed it in beamterm - which also translated to simplified mouse handling in ratzilla (-35 loc) |
Member
|
Cool, is this ready for review? |
Member
Author
it is now; and the offset bug was fixed after merging main into the branch. |
orhun
approved these changes
Mar 12, 2026
Member
There was a problem hiding this comment.
I feel like we should include this trait in either util module or move it under backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enabler for properly handling mouse wheel scroll events in #142
revolves around the
CellSizedtrait, implemented by all backends.