Skip to content

Nrf52 win #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NW-Lab wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Nrf52 win #58

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4621934
Merge pull request #1 from NW-Lab/new_devices
NW-Lab Nov 12, 2024
5c19d8b
Merge pull request #2 from NW-Lab/new_devices
NW-Lab Nov 16, 2024
182ab51
Merge branch 'main' of github.com:NW-Lab/node-red-mcu-plugin into main
Apr 30, 2025
02f655d
nrf52 for Windows
Apr 30, 2025
6e3056e
fix
Apr 30, 2025
c8ccec2
Merge branch 'main' into nrf52_win
NW-Lab Jan 18, 2026
ece1d0e
VS2026 Add for NRF52
NW-Lab Jan 18, 2026
975892a
Apply suggestions from code review
NW-Lab Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions mcu_plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,13 +2110,30 @@ module.exports = function(RED) {
case "pico":
case "gecko":
case "qca4020":
/* Not tested! */

case "nrf52":
case "sim":

bcmds.push(`runthis ${cmd}`);
break;

case "nrf52":
if (os.platform() === "win32") {
if (fs.existsSync(`${process.env["ProgramFiles"]}\\Microsoft Visual Studio\\18`)) {
bcmds = [
`CALL "${process.env["ProgramFiles"]}\\Microsoft Visual Studio\\18\\Community\\VC\\Auxiliary\\Build\\vcvars64.bat"`,
Comment thread
NW-Lab marked this conversation as resolved.
`@echo ${cmd}`,
`${cmd}`,
]
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing comma in the array literal. JavaScript requires commas between array elements. Add a comma after the closing bracket on this line.

Copilot uses AI. Check for mistakes.
} else {
bcmds = [
`CALL "${process.env["ProgramFiles"]}\\Microsoft Visual Studio\\2022\\Community\\VC\\Auxiliary\\Build\\vcvars${x_win}.bat"`,
`@echo ${cmd}`,
`${cmd}`,
]
Copy link

Copilot AI Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing trailing comma in the array literal. JavaScript requires commas between array elements. Add a comma after the closing bracket on this line.

Copilot uses AI. Check for mistakes.
}
} else {
bcmds.push(`runthis ${cmd}`);
}
break;

case "esp":

Expand Down