Conversation
Moddable 5.1.0 add devices
Moddable SDK 5.2.0 Add Devices
There was a problem hiding this comment.
Pull request overview
This pull request adds Windows build support for nRF52 MCU targets. The nrf52 case is moved from the "Not tested!" section and given its own platform-specific build logic that detects Visual Studio installations and configures the build commands accordingly.
Changes:
- Extracted nrf52 from the untested MCU types group into its own dedicated case handler
- Added Windows-specific logic to detect and use Microsoft Visual Studio build tools for nrf52 compilation
- Maintained non-Windows platforms using the existing runthis command pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| `CALL "${process.env["ProgramFiles"]}\\Microsoft Visual Studio\\18\\Community\\VC\\Auxiliary\\Build\\vcvars64.bat"`, | ||
| `@echo ${cmd}`, | ||
| `${cmd}`, | ||
| ] |
There was a problem hiding this comment.
Missing trailing comma in the array literal. JavaScript requires commas between array elements. Add a comma after the closing bracket on this line.
| `CALL "${process.env["ProgramFiles"]}\\Microsoft Visual Studio\\2022\\Community\\VC\\Auxiliary\\Build\\vcvars${x_win}.bat"`, | ||
| `@echo ${cmd}`, | ||
| `${cmd}`, | ||
| ] |
There was a problem hiding this comment.
Missing trailing comma in the array literal. JavaScript requires commas between array elements. Add a comma after the closing bracket on this line.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hello
I was able to build nRF52 on Windows.
Thank you