Skip to content

Conversation

@drorIvry
Copy link
Collaborator

@drorIvry drorIvry commented Jan 29, 2026

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Summary by CodeRabbit

  • New Features

    • Added optional metadata parameter to evaluation operations, enabling users to include custom context information with both evaluation requests and invocations for enhanced tracking and operational visibility.
  • Version

    • Bumped to version 0.15.0

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 29, 2026

Walkthrough

Version bumped to 0.15.0. Optional metadata parameters (Dictionary[str, str]) added to Client.evaluate and Client.invoke_evaluation methods, with corresponding fields added to EvaluationRequest and EvaluationInvokeRequest types. Metadata is threaded through request payload construction.

Changes

Cohort / File(s) Summary
Version Management
pyproject.toml
Bumped project version from 0.14.0 to 0.15.0.
Client API Methods
qualifire/client.py
Added optional metadata: Optional[Dict[str, str]] parameter to evaluate() and invoke_evaluation() methods with updated docstrings; metadata passed to respective request constructors.
Request Types
qualifire/types.py
Added optional metadata: Optional[Dict[str, str]] field to EvaluationRequest and EvaluationInvokeRequest classes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Metadata now flows through requests divine,
Parameters thread with a hop and a sign,
From client to types, the chain runs true,
Simple and clean—version 0.15 is new! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Feature - user metadata' directly aligns with the main changes, which add a metadata parameter throughout the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/user-metadata-FIRE-1096

Comment @coderabbitai help to get the list of available commands and usage tips.

@drorIvry drorIvry requested a review from yuval-qf January 29, 2026 21:14
Copy link
Contributor

@yuval-qf yuval-qf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drorIvry drorIvry merged commit 052eb71 into main Jan 30, 2026
9 checks passed
@drorIvry drorIvry deleted the feature/user-metadata-FIRE-1096 branch January 30, 2026 08:28
@coderabbitai coderabbitai bot mentioned this pull request Feb 1, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants