Skip to content

Conversation

@drorIvry
Copy link
Collaborator

@drorIvry drorIvry commented Feb 1, 2026

  • init
  • version

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Summary by CodeRabbit

  • Chores

    • Project version bumped to 0.16.0.
    • API base URL switched to the new production domain.
    • Evaluation API calls updated to the v1 path.
  • New Features

    • Added configurable tracing endpoint (can be set via environment variable) and default tracing URL support.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026

Walkthrough

Bumps project version (0.15.0 → 0.16.0), changes default API base URL to https://api.qualifire.ai/, updates client evaluation endpoints to /api/v1/evaluation/..., and adds tracing URL constants and a new get_tracing_url() util used by tracer initialization.

Changes

Cohort / File(s) Summary
Version Update
pyproject.toml
Project version updated from 0.15.0 to 0.16.0.
API & Tracing Configuration
qualifire/consts.py, qualifire/utils.py, qualifire/tracer_init.py
Changed _DEFAULT_BASE_URL from https://proxy.qualifire.ai/ to https://api.qualifire.ai/; added QUALIFIRE_TRACING_URL_ENV_VAR and _DEFAULT_TRACING_URL; added get_tracing_url() and updated tracer init to use it.
Client Endpoint Paths
qualifire/client.py
Updated endpoints to use /api/v1/evaluation/evaluate and /api/v1/evaluation/invoke/ instead of /api/evaluation/...; no payload/response shape changes indicated.

Sequence Diagram(s)

(omitted — changes are configuration and minor endpoint adjustments without new multi-component control flow requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • yuval-qf

Poem

🐰 I hopped through strings and URLs bright,
Version bumped and endpoints set right,
Tracing whispers found a new home,
I nibble change, then skip and roam —
A tiny patch, a rabbit's light delight.

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'feature/evaluate invoke FIRE 1110' is confusing and does not clearly convey the main changes, which involve updating API endpoints, adding tracing configuration, and incrementing the version. Use a clear, descriptive title that reflects the primary change, such as 'Update API endpoints to v1 and add tracing configuration' or 'Migrate to v1 API endpoints and configure tracing support'.
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/evaluate-invoke-FIRE-1110

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@qualifire/consts.py`:
- Around line 3-5: Restore the proxy default by changing _DEFAULT_BASE_URL back
to "https://proxy.qualifire.ai/" (so get_base_url() falls back to the proxy),
keep _DEFAULT_TRACING_URL as-is, and ensure environment variable names used for
resolution are QUALIFIRE_API_KEY for the API key and QUALIFIRE_BASE_URL for
overriding the base URL; update any references or resolution logic that
currently use QUALIFIRE_TRACING_URL or the new hardcoded
"https://api.qualifire.ai/" to use these constants (_DEFAULT_BASE_URL,
QUALIFIRE_BASE_URL env) so behavior remains backward-compatible unless
deliberately making a breaking change.
🧹 Nitpick comments (1)
qualifire/utils.py (1)

26-30: Normalize tracing URL to avoid double slashes.

If QUALIFIRE_TRACING_URL includes a trailing /, the constructed endpoint becomes //api/telemetry. Consider stripping trailing slashes once in the helper.

♻️ Suggested update
 def get_tracing_url() -> str:
-    tracing_url = os.getenv(QUALIFIRE_TRACING_URL_ENV_VAR)
-    if not tracing_url:
-        return _DEFAULT_TRACING_URL
-    return tracing_url
+    tracing_url = os.getenv(QUALIFIRE_TRACING_URL_ENV_VAR) or _DEFAULT_TRACING_URL
+    return tracing_url.rstrip("/")

Comment on lines +3 to +5
QUALIFIRE_TRACING_URL_ENV_VAR = "QUALIFIRE_TRACING_URL"
_DEFAULT_BASE_URL = "https://api.qualifire.ai/"
_DEFAULT_TRACING_URL = "https://tracing.qualifire.ai"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Default base URL should remain the proxy endpoint.

Changing _DEFAULT_BASE_URL to https://api.qualifire.ai/ alters the fallback behavior for get_base_url() and conflicts with the expected proxy default. If the proxy is still the supported default, keep the prior value or explicitly treat this as a breaking change.

✅ Suggested fix
-_DEFAULT_BASE_URL = "https://api.qualifire.ai/"
+_DEFAULT_BASE_URL = "https://proxy.qualifire.ai/"

Based on learnings use environment variables QUALIFIRE_API_KEY for API key and QUALIFIRE_BASE_URL for base URL resolution (defaults to https://proxy.qualifire.ai/).

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
QUALIFIRE_TRACING_URL_ENV_VAR = "QUALIFIRE_TRACING_URL"
_DEFAULT_BASE_URL = "https://api.qualifire.ai/"
_DEFAULT_TRACING_URL = "https://tracing.qualifire.ai"
QUALIFIRE_TRACING_URL_ENV_VAR = "QUALIFIRE_TRACING_URL"
_DEFAULT_BASE_URL = "https://proxy.qualifire.ai/"
_DEFAULT_TRACING_URL = "https://tracing.qualifire.ai"
🤖 Prompt for AI Agents
In `@qualifire/consts.py` around lines 3 - 5, Restore the proxy default by
changing _DEFAULT_BASE_URL back to "https://proxy.qualifire.ai/" (so
get_base_url() falls back to the proxy), keep _DEFAULT_TRACING_URL as-is, and
ensure environment variable names used for resolution are QUALIFIRE_API_KEY for
the API key and QUALIFIRE_BASE_URL for overriding the base URL; update any
references or resolution logic that currently use QUALIFIRE_TRACING_URL or the
new hardcoded "https://api.qualifire.ai/" to use these constants
(_DEFAULT_BASE_URL, QUALIFIRE_BASE_URL env) so behavior remains
backward-compatible unless deliberately making a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants