Skip to content

chore(multimedia): fix ShellCheck SC2317 warnings in audio, camera, fastrpc, and video tests #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnarapar merged 4 commits into from
Apr 7, 2026
Merged

chore(multimedia): fix ShellCheck SC2317 warnings in audio, camera, fastrpc, and video tests #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e0f86b
The Audio_Playback testcase defines a cleanup() helper that is invoked
smuppand Apr 7, 2026
2fde3ea
Libcamera_cam printed artifact locations after the final PASS/FAIL exit
smuppand Apr 7, 2026
5540e82
fastrpc_test keeps a small log_debug() helper for optional verbose debug
smuppand Apr 7, 2026
9969c6f
Video_V4L2_Runner already exits from all branches of the final overall
smuppand Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Runner/suites/Multimedia/CDSP/fastrpc_test/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ cd "$test_path" || {
}

# -------------------- Helpers --------------------
# shellcheck disable=SC2317 # Helper kept for optional debug use.
log_debug() { [ "$VERBOSE" -eq 1 ] && log_info "[debug] $*"; }

cmd_to_string() {
Expand Down
14 changes: 7 additions & 7 deletions Runner/suites/Multimedia/Camera/Libcamera_cam/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,13 @@ else
fi
log_info "Summary file: $OUT_DIR/summary.txt"

# ---------- Artifacts ----------
log_info "Artifacts under: $OUT_DIR/"
for IDX in $INDICES; do
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
log_info " - $CAM_DIR/"
done

# ---------- Final verdict ----------
if [ "$OVERALL_PASS" -eq 1 ] && [ $ANY_RC_NONZERO -eq 0 ]; then
echo "$TESTNAME PASS" > "$RES_FILE"
Expand All @@ -294,10 +301,3 @@ else
log_fail "$TESTNAME FAIL"
exit 1
fi

# ---------- Artifacts ----------
log_info "Artifacts under: $OUT_DIR/"
for IDX in $INDICES; do
CAM_DIR="${OUT_DIR%/}/cam${IDX}"
log_info " - $CAM_DIR/"
done
1 change: 1 addition & 0 deletions Runner/suites/Multimedia/GSTreamer/Audio/Audio_Playback/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ if [ -n "$channels" ]; then
channelsUser="1"
fi

# shellcheck disable=SC2317 # Invoked indirectly via trap.
cleanup() {
pkill -x gst-launch-1.0 >/dev/null 2>&1 || true
}
Expand Down
2 changes: 0 additions & 2 deletions Runner/suites/Multimedia/Video/Video_V4L2_Runner/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,5 +1386,3 @@ else
printf '%s\n' "$TESTNAME FAIL" >"$RES_FILE"
exit 1
fi

exit "$suite_rc"
Loading