chore(multimedia): fix ShellCheck SC2317 warnings in audio, camera, fastrpc, and video tests#390
Merged
vnarapar merged 4 commits intoqualcomm-linux:mainfrom Apr 7, 2026
Merged
Conversation
indirectly via trap on EXIT/INT/TERM. ShellCheck reports SC2317 on the pkill call because it cannot see the trap-based invocation path, but the function is valid and part of the existing cleanup flow. Add a targeted SC2317 suppression on cleanup() without changing runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
path, making that block unreachable and triggering ShellCheck SC2317. Move the artifact summary logging above the final verdict so the logs are actually emitted while preserving the existing PASS/FAIL behavior and result-file flow. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
use, but ShellCheck flags it with SC2317 because it is not exercised in the normal visible path. Add a narrow SC2317 suppression for the helper without changing the current test flow or runtime behavior. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
result block, so the trailing exit is dead code and triggers ShellCheck SC2317. Remove the unreachable exit without changing the testcase result flow, logging, or exit semantics. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a small set of ShellCheck SC2317 warnings in multimedia test scripts without changing the existing runtime behavior.
What is changed:
Why this is needed:
ShellCheck reported a mix of true unreachable code and indirect-use helpers that it could not statically resolve. This PR fixes the real unreachable blocks and uses narrow suppressions only where the code is intentionally reachable through trap or optional helper flow.
Impact: