fix: unbreak main branch builds#3716
Conversation
dl-bot-integrations
requested review from
a team and
tejasbadadare
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| [package] | ||
| name = "fortuna" | ||
| version = "9.4.0" | ||
| version = "9.4.1" |
There was a problem hiding this comment.
🟡 Cargo.lock not updated after fortuna version bump
The fortuna Cargo.toml version was bumped from 9.4.0 to 9.4.1, but the workspace Cargo.lock still records version = "9.4.0" for the fortuna package. This violates the AGENTS.md rule: "Important: When changing code, bump the package version in Cargo.toml based on semantic versioning. Run cargo check to ensure the changes are reflected in the Cargo.lock lockfile." Running cargo check or cargo update -p fortuna would synchronize the lockfile.
Prompt for agents
The Cargo.lock file in the repository root still lists fortuna as version 9.4.0 even though apps/fortuna/Cargo.toml was bumped to 9.4.1. Run `cargo check` (or `cargo generate-lockfile`) from the workspace root so Cargo.lock reflects the new version. The AGENTS.md at apps/fortuna/AGENTS.md explicitly requires this step.
Was this helpful? React with 👍 or 👎 to provide feedback.
| rand = "0.7.0" | ||
| serde_json = "1.0.96" | ||
| solana-client = ">=1.13.6" | ||
| solana-program = ">=1.13.6" |
There was a problem hiding this comment.
🟡 Cargo.lock not updated after adding solana-program dev-dependency to pythnet_sdk
A new dev-dependency solana-program = ">=1.13.6" was added to pythnet/pythnet_sdk/Cargo.toml, but the workspace Cargo.lock was not regenerated. The [[package]] entry for pythnet-sdk in Cargo.lock does not list solana-program as a dependency. This means building or testing this crate will either fail or silently regenerate the lockfile, which contradicts the AGENTS.md guideline to run cargo check to ensure lock file changes are committed alongside Cargo.toml changes.
Prompt for agents
After adding solana-program to dev-dependencies in pythnet/pythnet_sdk/Cargo.toml, run `cargo check` or `cargo generate-lockfile` from the workspace root so Cargo.lock is updated in the same commit. The AGENTS.md rule at apps/fortuna/AGENTS.md requires lockfile changes to be included when Cargo.toml is modified.
Was this helpful? React with 👍 or 👎 to provide feedback.
| chrono::DateTime, | ||
| ethers::{ | ||
| core::utils::hex::ToHex, | ||
| core::utils::hex::ToHexExt, |
There was a problem hiding this comment.
🚩 ToHex → ToHexExt trait migration: test code uses turbofish syntax
The import was changed from ToHex to ToHexExt at apps/fortuna/src/history.rs:6. The non-test code only calls encode_hex() without turbofish, which works with both traits. However, the test code at lines 775, 785, 796, 825, 834, 845, 875, 885, 897 uses encode_hex::<String>() turbofish syntax. The ToHex trait defines encode_hex<T: FromIterator<char>>(&self) -> T (generic), while ToHexExt defines encode_hex(&self) -> String (no generic). If the ethers re-export of ToHexExt matches the standard hex crate's definition, these turbofish calls would be compile errors. This would be caught by CI, but worth noting as it suggests the migration may be incomplete.
Was this helpful? React with 👍 or 👎 to provide feedback.
| { | ||
| "dependencies": { | ||
| "@evolution-sdk/evolution": "^0.3.29" | ||
| "@evolution-sdk/evolution": "0.3.28" |
There was a problem hiding this comment.
🚩 Dependency downgrade from ^0.3.29 to pinned 0.3.28
The @evolution-sdk/evolution dependency was changed from ^0.3.29 (allowing 0.3.29+) to the exact pinned version 0.3.28. This is a downgrade that also pins to a specific version rather than allowing semver-compatible updates. The pnpm-lock.yaml was updated accordingly (previously resolved to 0.3.32, now locked to 0.3.28). This could be intentional (e.g., a regression in newer versions), but it's worth confirming the reason for the downgrade and whether pinning (vs ^0.3.28) is intentional.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Bug Description
mainis red across several workflows. The primary breakage islazer/contracts/cardano/sdk/js, where a floating@evolution-sdk/evolutiondependency resolved to0.3.32, which no longer exports the symbols this package uses.This branch also addresses the other independent CI failures currently showing on
main.Root Cause
@evolution-sdk/evolutiondrifted from the compatible API surface expected by the Cardano SDK package.main:pythnet_sdkexample referencedsolana_sdk::system_programfortunaused deprecatedToHexFix
@evolution-sdk/evolutionto0.3.28in the Cardano SDK package and lockfilepythnet_sdk/examples/generate_pyth_data.rsto usesolana_program::system_programand add the dev dependencyToHexExtand bump patch version to9.4.1How to Verify
pnpm install --frozen-lockfile --filter @pythnetwork/pyth-lazer-cardano-jspnpm --filter @pythnetwork/pyth-lazer-cardano-js buildTest Plan
Local verification run:
pnpm install --frozen-lockfile --filter @pythnetwork/pyth-lazer-cardano-jspnpm --filter @pythnetwork/pyth-lazer-cardano-js buildNote: I could not run local Rust verification on this machine because
cargois not installed here, so the Rust portions are based on the exact GitHub Actions failures frommain.Risk Assessment
Medium — the JS fix is narrowly scoped, but this PR also batches three small CI-unblocking Rust changes so the blast radius spans multiple packages. Each change is surgical and mapped directly to current failing workflows.