Skip to content

fix: unbreak main branch builds #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dl-bot-integrations wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: unbreak main branch builds #3716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/fortuna/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "fortuna"
version = "9.4.0"
version = "9.4.1"
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Cargo.lock not updated after fortuna version bump

The fortuna Cargo.toml version was bumped from 9.4.0 to 9.4.1, but the workspace Cargo.lock still records version = "9.4.0" for the fortuna package. This violates the AGENTS.md rule: "Important: When changing code, bump the package version in Cargo.toml based on semantic versioning. Run cargo check to ensure the changes are reflected in the Cargo.lock lockfile." Running cargo check or cargo update -p fortuna would synchronize the lockfile.

Prompt for agents 
The Cargo.lock file in the repository root still lists fortuna as version 9.4.0 even though apps/fortuna/Cargo.toml was bumped to 9.4.1. Run `cargo check` (or `cargo generate-lockfile`) from the workspace root so Cargo.lock reflects the new version. The AGENTS.md at apps/fortuna/AGENTS.md explicitly requires this step.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

edition = "2021"

[lib]
Expand Down
2 changes: 1 addition & 1 deletion apps/fortuna/src/history.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
anyhow::Result,
chrono::DateTime,
ethers::{
core::utils::hex::ToHex,
core::utils::hex::ToHexExt,
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 ToHex → ToHexExt trait migration: test code uses turbofish syntax

The import was changed from ToHex to ToHexExt at apps/fortuna/src/history.rs:6. The non-test code only calls encode_hex() without turbofish, which works with both traits. However, the test code at lines 775, 785, 796, 825, 834, 845, 875, 885, 897 uses encode_hex::<String>() turbofish syntax. The ToHex trait defines encode_hex<T: FromIterator<char>>(&self) -> T (generic), while ToHexExt defines encode_hex(&self) -> String (no generic). If the ethers re-export of ToHexExt matches the standard hex crate's definition, these turbofish calls would be compile errors. This would be caught by CI, but worth noting as it suggests the migration may be incomplete.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

prelude::TxHash,
types::{Address, Bytes, U256},
utils::keccak256,
Expand Down Expand Up @@ -772,7 +772,7 @@
.query()
.search(format!(
"0x{}",
status.request_tx_hash.encode_hex::<String>()

Check failure on line 775 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 775 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
))
.unwrap()
.execute()
Expand All @@ -782,7 +782,7 @@

let logs = history
.query()
.search(status.request_tx_hash.encode_hex::<String>().to_uppercase())

Check failure on line 785 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 785 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
.unwrap()
.execute()
.await
Expand All @@ -793,7 +793,7 @@
.query()
.search(format!(
"0x{}",
status.request_tx_hash.encode_hex::<String>().to_uppercase()

Check failure on line 796 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 796 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
))
.unwrap()
.execute()
Expand Down Expand Up @@ -822,7 +822,7 @@

let logs = history
.query()
.search(format!("0x{}", reveal_tx_hash.encode_hex::<String>()))

Check failure on line 825 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 825 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
.unwrap()
.execute()
.await
Expand All @@ -831,7 +831,7 @@

let logs = history
.query()
.search(reveal_tx_hash.encode_hex::<String>().to_uppercase())

Check failure on line 834 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 834 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
.unwrap()
.execute()
.await
Expand All @@ -842,7 +842,7 @@
.query()
.search(format!(
"0x{}",
reveal_tx_hash.encode_hex::<String>().to_uppercase()

Check failure on line 845 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 845 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
))
.unwrap()
.execute()
Expand Down Expand Up @@ -872,7 +872,7 @@

let logs = history
.query()
.search(format!("0x{}", status.sender.encode_hex::<String>()))

Check failure on line 875 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 875 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
.unwrap()
.network_id(status.network_id)
.execute()
Expand All @@ -882,7 +882,7 @@

let logs = history
.query()
.search(status.sender.encode_hex::<String>().to_uppercase())

Check failure on line 885 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 885 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
.unwrap()
.network_id(status.network_id)
.execute()
Expand All @@ -894,7 +894,7 @@
.query()
.search(format!(
"0x{}",
status.sender.encode_hex::<String>().to_uppercase()

Check failure on line 897 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied

Check failure on line 897 in apps/fortuna/src/history.rs

View workflow job for this annotation

GitHub Actions / test 

method takes 0 generic arguments but 1 generic argument was supplied
))
.unwrap()
.network_id(status.network_id)
Expand Down
2 changes: 1 addition & 1 deletion lazer/contracts/cardano/sdk/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"dependencies": {
"@evolution-sdk/evolution": "^0.3.29"
"@evolution-sdk/evolution": "0.3.28"
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Dependency downgrade from ^0.3.29 to pinned 0.3.28

The @evolution-sdk/evolution dependency was changed from ^0.3.29 (allowing 0.3.29+) to the exact pinned version 0.3.28. This is a downgrade that also pins to a specific version rather than allowing semver-compatible updates. The pnpm-lock.yaml was updated accordingly (previously resolved to 0.3.32, now locked to 0.3.28). This could be intentional (e.g., a regression in newer versions), but it's worth confirming the reason for the downgrade and whether pinning (vs ^0.3.28) is intentional.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

},
"description": "User-facing SDK for the Pyth Lazer Cardano integration",
"devDependencies": {
Expand Down
26 changes: 2 additions & 24 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pythnet/pythnet_sdk/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ base64 = "0.21.0"
rand = "0.7.0"
serde_json = "1.0.96"
solana-client = ">=1.13.6"
solana-program = ">=1.13.6"
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Cargo.lock not updated after adding solana-program dev-dependency to pythnet_sdk

A new dev-dependency solana-program = ">=1.13.6" was added to pythnet/pythnet_sdk/Cargo.toml, but the workspace Cargo.lock was not regenerated. The [[package]] entry for pythnet-sdk in Cargo.lock does not list solana-program as a dependency. This means building or testing this crate will either fail or silently regenerate the lockfile, which contradicts the AGENTS.md guideline to run cargo check to ensure lock file changes are committed alongside Cargo.toml changes.

Prompt for agents 
After adding solana-program to dev-dependencies in pythnet/pythnet_sdk/Cargo.toml, run `cargo check` or `cargo generate-lockfile` from the workspace root so Cargo.lock is updated in the same commit. The AGENTS.md rule at apps/fortuna/AGENTS.md requires lockfile changes to be included when Cargo.toml is modified.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

solana-sdk = ">=1.13.6"
proptest = "1.1.0"

Expand Down
3 changes: 2 additions & 1 deletion pythnet/pythnet_sdk/examples/generate_pyth_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
pythnet_sdk::pythnet::PYTH_PID,
serde_json::json,
solana_client::rpc_client::RpcClient,
solana_program::system_program,

Check failure on line 9 in pythnet/pythnet_sdk/examples/generate_pyth_data.rs

View workflow job for this annotation

GitHub Actions / test 

unresolved import `solana_program::system_program`

Check failure on line 9 in pythnet/pythnet_sdk/examples/generate_pyth_data.rs

View workflow job for this annotation

GitHub Actions / test 

unresolved import `solana_program::system_program`
solana_sdk::pubkey::Pubkey,
std::{io::Write, str::FromStr},
};
Expand Down Expand Up @@ -113,7 +114,7 @@
for i in 0..10_000u32 {
let (accumulator_account, _) = Pubkey::find_program_address(
&[b"AccumulatorState", &PYTH_PID, &i.to_be_bytes()],
&solana_sdk::system_program::id(),
&system_program::id(),
);
file.write_all(format!("{accumulator_account}\n").as_bytes())
.unwrap();
Expand Down
8 changes: 4 additions & 4 deletions target_chains/cosmwasm/contracts/pyth/src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,19 @@ pub struct ConfigInfo {
pub fee: Coin,
}

pub fn config(storage: &mut dyn Storage) -> Singleton<ConfigInfo> {
pub fn config(storage: &mut dyn Storage) -> Singleton<'_, ConfigInfo> {
singleton(storage, CONFIG_KEY)
}

pub fn config_read(storage: &dyn Storage) -> ReadonlySingleton<ConfigInfo> {
pub fn config_read(storage: &dyn Storage) -> ReadonlySingleton<'_, ConfigInfo> {
singleton_read(storage, CONFIG_KEY)
}

pub fn price_feed_bucket(storage: &mut dyn Storage) -> Bucket<PriceFeed> {
pub fn price_feed_bucket(storage: &mut dyn Storage) -> Bucket<'_, PriceFeed> {
bucket(storage, PRICE_FEED_KEY)
}

pub fn price_feed_read_bucket(storage: &dyn Storage) -> ReadonlyBucket<PriceFeed> {
pub fn price_feed_read_bucket(storage: &dyn Storage) -> ReadonlyBucket<'_, PriceFeed> {
bucket_read(storage, PRICE_FEED_KEY)
}

Expand Down
Loading