Skip to content

Add a method to load a VmecWout object from a NetCDF file.#86

Merged
jons-pf merged 2 commits intomainfrom
jons-add-vmec-wout-load-2
Mar 14, 2025
Merged

Add a method to load a VmecWout object from a NetCDF file.#86
jons-pf merged 2 commits intomainfrom
jons-add-vmec-wout-load-2

Conversation

@jons-pf
Copy link
Copy Markdown
Collaborator

@jons-pf jons-pf commented Feb 6, 2025

No description provided.

Copy link
Copy Markdown
Collaborator Author

jons-pf commented Feb 6, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from 514e2da to f468384 Compare February 6, 2025 15:07
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 78965cd to 58d4166 Compare February 6, 2025 15:07
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from f468384 to dcf0423 Compare February 6, 2025 15:20
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 58d4166 to e817d33 Compare February 6, 2025 15:20
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from dcf0423 to f14bb50 Compare February 6, 2025 15:43
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from e817d33 to 9c7f505 Compare February 6, 2025 15:43
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from f14bb50 to 742023c Compare February 6, 2025 15:45
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch 2 times, most recently from 2e6ae91 to a9f475e Compare February 6, 2025 16:14
@jons-pf jons-pf requested a review from eguiraud-pf February 6, 2025 16:22
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from a9f475e to 35608ae Compare February 6, 2025 16:22
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from 742023c to 85994ec Compare February 14, 2025 12:37
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 35608ae to 231595d Compare February 14, 2025 12:37
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from 85994ec to f435664 Compare February 14, 2025 13:20
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 231595d to 92d4fbd Compare February 14, 2025 13:20
@eguiraud-pf eguiraud-pf removed their request for review February 14, 2025 13:51
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from f435664 to 97142b3 Compare February 14, 2025 13:57
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 92d4fbd to ff24e32 Compare February 14, 2025 13:57
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from 97142b3 to e1c4419 Compare February 14, 2025 14:03
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch 2 times, most recently from 04b8835 to 551834f Compare February 14, 2025 14:05
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from e1c4419 to f7e0e5c Compare February 14, 2025 14:05
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 551834f to 01aab3c Compare February 14, 2025 14:19
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from f7e0e5c to 64e14be Compare February 17, 2025 10:52
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch 2 times, most recently from a790d60 to 88fd973 Compare February 18, 2025 06:02
@jons-pf jons-pf force-pushed the jons-compute-jxb-gradp-even-if-not-converged-2 branch from 67c812c to f4dea5d Compare March 5, 2025 17:11
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from dbdc3e2 to 2796621 Compare March 5, 2025 17:11
@jons-pf jons-pf changed the base branch from jons-compute-jxb-gradp-even-if-not-converged-2 to graphite-base/86 March 5, 2025 17:13
@jons-pf jons-pf force-pushed the graphite-base/86 branch from f4dea5d to e40bf4e Compare March 5, 2025 17:35
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 2796621 to b9bbe17 Compare March 5, 2025 17:35
@jons-pf jons-pf force-pushed the graphite-base/86 branch from e40bf4e to b5409d4 Compare March 5, 2025 17:36
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from b9bbe17 to 04ecd08 Compare March 5, 2025 17:36
@jons-pf jons-pf changed the base branch from graphite-base/86 to jons-compute-jxb-gradp-even-if-not-converged-2 March 5, 2025 17:37
@jons-pf jons-pf requested a review from eguiraud-pf March 5, 2025 17:45
Copy link
Copy Markdown
Collaborator

@eguiraud-pf eguiraud-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! only missing a simple test that the contents of the read wout are correct

@jons-pf jons-pf changed the base branch from jons-compute-jxb-gradp-even-if-not-converged-2 to graphite-base/86 March 5, 2025 21:35
@jons-pf jons-pf force-pushed the graphite-base/86 branch from b5409d4 to 3cf7fe8 Compare March 5, 2025 21:37
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from 04ecd08 to 28eee4d Compare March 5, 2025 21:37
@jons-pf jons-pf changed the base branch from graphite-base/86 to main March 5, 2025 21:38
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch 4 times, most recently from 01a8fcd to ca58d4e Compare March 9, 2025 17:33
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from ca58d4e to f7ef06a Compare March 13, 2025 19:40
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch 3 times, most recently from 83394f6 to adef7d1 Compare March 14, 2025 10:04
@jons-pf jons-pf force-pushed the jons-add-vmec-wout-load-2 branch from adef7d1 to 0cb20d9 Compare March 14, 2025 10:56
@jons-pf jons-pf requested a review from eguiraud-pf March 14, 2025 10:57
Copy link
Copy Markdown
Collaborator Author

jons-pf commented Mar 14, 2025

Merge activity

  • Mar 14, 9:51 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 14, 9:51 AM EDT: A user merged this pull request with Graphite.

@jons-pf jons-pf merged commit 54c003f into main Mar 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants