Skip to content

Allow to return VMEC++ outputs even if the run did not converge.#84

Merged
jons-pf merged 3 commits intomainfrom
jons-vmecpp-return-results-even-if-not-converged-2
Mar 5, 2025
Merged

Allow to return VMEC++ outputs even if the run did not converge.#84
jons-pf merged 3 commits intomainfrom
jons-vmecpp-return-results-even-if-not-converged-2

Conversation

@jons-pf
Copy link
Copy Markdown
Collaborator

@jons-pf jons-pf commented Feb 6, 2025

No description provided.

Copy link
Copy Markdown
Collaborator Author

jons-pf commented Feb 6, 2025

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Feb 10, 2025

Merge activity

  • Feb 10, 5:36 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Mar 5, 11:35 AM EST: A user merged this pull request with Graphite.

@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 2 times, most recently from 0026851 to 7f01603 Compare February 14, 2025 13:20
@eguiraud-pf eguiraud-pf removed their request for review February 14, 2025 13:51
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 3 times, most recently from 965e313 to 6346582 Compare February 14, 2025 14:05
@jons-pf jons-pf requested a review from eguiraud-pf February 14, 2025 14:07
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 3 times, most recently from 429c3cd to 080516e Compare February 19, 2025 06:55
Comment thread src/vmecpp/__init__.py Outdated
Comment thread src/vmecpp/__init__.py Outdated
Comment thread src/vmecpp/cpp/vmecpp/vmec/output_quantities/output_quantities.h
Comment thread tests/test_init.py
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch from ff5f2f2 to 3118ba7 Compare March 5, 2025 15:42
@jons-pf jons-pf merged commit 5676d3f into main Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants