Skip to content

chore(ci): drop code-review workflow — superseded by Quinn#3746

Merged
mabry1985 merged 1 commit into
mainfrom
chore/drop-review-code-workflow
May 24, 2026
Merged

chore(ci): drop code-review workflow — superseded by Quinn#3746
mabry1985 merged 1 commit into
mainfrom
chore/drop-review-code-workflow

Conversation

@mabry1985
Copy link
Copy Markdown
Contributor

@mabry1985 mabry1985 commented May 24, 2026

Summary

Quinn (protoWorkstacean) now handles PR review via the webhook at `hooks.proto-labs.ai/webhook/github` — id 604878011 on this repo, active, subscribed to all PR + issue events.

Quinn:

  • Inline review via the GitHub Review API (line-level, not sticky comments)
  • Vector context from Qdrant (`quinn-pr-history`, `quinn-code-patterns`)
  • Learning loop (`quinn-review-learnings` filters low-signal patterns)
  • Webhook-driven (no CI minutes)

`review-code` was the bridge tool we added in #3615 to bypass clawpatch's OpenAI-Codex coupling (#3614). With Quinn live, it's redundant.

Removed

  • `.github/workflows/code-review.yml` — the CI workflow
  • `scripts/post-review-findings.mjs` — sticky-comment helper used only by that workflow

What still gates PRs

Surface Gate
build / test / checks Required status checks (still enforced)
Quinn (protoquinn[bot]) Reviews every PR via webhook, blocks via reviewDecision if it submits CHANGES_REQUESTED
CodeRabbit Reviews every PR via app, gates the same way (advisory unless CHANGES_REQUESTED)

Related

  • Companion PR in release-tools coming up to strip the `review-code` bin/lib/tests entirely + bump to 2.0
  • Companion PR in escape-from-qud to remove its copy of this workflow

Summary by CodeRabbit

  • Chores
    • Removed internal code review automation workflow and associated script. This streamlines the development infrastructure by eliminating redundant automation processes.

Review Change Stack

Quinn (protoWorkstacean) now handles PR review on this repo via the
hook registered at hooks.proto-labs.ai/webhook/github. Quinn does
inline review via the GitHub Review API, vector-context search against
prior PR history (quinn-pr-history), and a learning loop that filters
low-signal dismissed comments — strictly better than the
release-tools/review-code sticky-comment approach this workflow ran.

Quinn explicitly "replaces CodeRabbit" per its reference doc, and our
review-code CLI was the bridge tool added in #3615 to bypass clawpatch's
OpenAI-Codex coupling (#3614). Both are now redundant for the PR-review
job.

Removes:
- .github/workflows/code-review.yml — the CI workflow that ran review-code
- scripts/post-review-findings.mjs — sticky-comment helper used only by the workflow

Quinn webhook on this repo (id 604878011) remains active and unaffected.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c969cf16-38ac-49cf-9ce1-bcc59dd5e371

📥 Commits

Reviewing files that changed from the base of the PR and between d58c620 and fb2568f.

📒 Files selected for processing (2)
  • .github/workflows/code-review.yml
  • scripts/post-review-findings.mjs
💤 Files with no reviewable changes (2)
  • scripts/post-review-findings.mjs
  • .github/workflows/code-review.yml

📝 Walkthrough

Walkthrough

Two automation files are deleted: the code-review GitHub Actions workflow that ran protoLabsAI/release-tools review-code and posted findings as PR comments, and the post-review-findings.mjs script that patched or created sticky comment markers for those reports.

Changes

Removal of code review automation

Layer / File(s) Summary
Remove code review workflow and reporting script
.github/workflows/code-review.yml, scripts/post-review-findings.mjs
The code-review workflow definition and post-review-findings Node CLI script are removed entirely, deleting the automated code review report generation and PR commenting integration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • protoLabsAI/protoMaker#3615: Both PRs modify the same CI integration points—.github/workflows/code-review.yml and scripts/post-review-findings.mjs—with this PR removing them while the retrieved PR introduces/updates them for the gateway-based review-code.

Suggested reviewers

  • protoquinn

Poem

🐰 A workflow's gone, a script put to rest,
No more reviews from the automated test,
The rabbit cleans up what's no longer blessed,
In silence they vanish—sometimes that's best!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(ci): drop code-review workflow — superseded by Quinn' directly and accurately summarizes the main change: removing the code-review workflow because Quinn now handles PR reviews.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-review-code-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@mabry1985 mabry1985 enabled auto-merge (squash) May 24, 2026 20:11
@mabry1985 mabry1985 merged commit 7b9303e into main May 24, 2026
6 checks passed
@mabry1985 mabry1985 deleted the chore/drop-review-code-workflow branch May 24, 2026 20:13
mabry1985 added a commit to protoLabsAI/release-tools that referenced this pull request May 24, 2026
)

BREAKING CHANGE: The `review-code` CLI is removed.

Quinn (in protoLabsAI/protoWorkstacean) now handles PR review across
the org via the webhook at hooks.proto-labs.ai/webhook/github. Quinn:

  - Reviews every PR via the GitHub webhook (opened, synchronize, ready_for_review)
  - Posts inline review comments via the GitHub Review API (line-level)
  - Uses Qdrant + Ollama vector search across prior PR history
    (quinn-pr-history) and similar code patterns (quinn-code-patterns)
  - Learns from dismissed comments (quinn-review-learnings) and
    suppresses low-signal patterns on future reviews
  - Explicitly designed to replace CodeRabbit per its reference doc

The release-tools `review-code` CLI was a bridge tool — added to bypass
clawpatch's OpenAI-Codex coupling so we could run Clawpatch-shaped
findings through the protoLabs gateway. With Quinn live, it's redundant
and removed in one shot rather than deprecated.

Removed:
  bin/review-code.mjs
  lib/code-review.mjs
  test/code-review.test.mjs
  docs/handoffs/2026-05-21-review-code.md

Updated:
  package.json    — drop bin entry, version 1.1.0 → 2.0.0
  .github/workflows/ci.yml — drop review-code lint/smoke steps
  README.md       — drop the "Model-backed code review" section

Consumers already migrated:
  protoLabsAI/protoMaker#3746
  protoLabsAI/escape-from-qud#109

Closes #9 (review-code: post sticky PR comment — no longer needed; Quinn
posts inline review comments natively).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant