Skip to content

feat!: remove review-code — superseded by Quinn (2.0.0)#12

Merged
mabry1985 merged 1 commit into
mainfrom
feat/remove-review-code-supersededb-by-quinn
May 24, 2026
Merged

feat!: remove review-code — superseded by Quinn (2.0.0)#12
mabry1985 merged 1 commit into
mainfrom
feat/remove-review-code-supersededb-by-quinn

Conversation

@mabry1985
Copy link
Copy Markdown
Contributor

BREAKING CHANGE. Removes the `review-code` CLI from `@protolabsai/release-tools` and bumps to 2.0.0.

Why

Quinn (in protoLabsAI/protoWorkstacean) now handles PR review across the org via webhook at `hooks.proto-labs.ai/webhook/github`. Quinn:

  • Reviews every PR via webhook (opened, synchronize, ready_for_review)
  • Posts inline review comments via the GitHub Review API — line-level, not sticky markdown
  • Vector search across prior PR history (`quinn-pr-history`) + symbol patterns (`quinn-code-patterns`)
  • Learns from dismissed comments and suppresses low-signal patterns
  • Per its reference doc, explicitly designed to replace CodeRabbit

`review-code` was a bridge — added to bypass clawpatch's OpenAI-Codex coupling so Clawpatch-shaped findings could route through the protoLabs gateway. With Quinn live, it's redundant. Per greenfield-first, remove rather than deprecate.

Removed

Path Bytes
`bin/review-code.mjs` 5,253
`lib/code-review.mjs` 25,850
`test/code-review.test.mjs` 6,789
`docs/handoffs/2026-05-21-review-code.md` 2,554

Updated

  • `package.json` — drop bin entry, drop from smoke command, version 1.1.0 → 2.0.0
  • `.github/workflows/ci.yml` — drop review-code syntax-check / help steps
  • `README.md` — drop the "Model-backed code review" section

Consumers already migrated

Both repos that called this in CI have companion PRs landing first:

Both had their Quinn webhooks verified active before this PR was opened. Webhook ids: protoMaker 604878011, escape-from-qud 630122469.

Test plan

  • `npm run lint` — clean
  • `npm run smoke` — all 3 remaining bin entries respond to `--help`
  • `npm test` — 13/13 branch-protection tests pass (the only remaining test surface)

Closes #9

BREAKING CHANGE: The `review-code` CLI is removed.

Quinn (in protoLabsAI/protoWorkstacean) now handles PR review across
the org via the webhook at hooks.proto-labs.ai/webhook/github. Quinn:

  - Reviews every PR via the GitHub webhook (opened, synchronize, ready_for_review)
  - Posts inline review comments via the GitHub Review API (line-level)
  - Uses Qdrant + Ollama vector search across prior PR history
    (quinn-pr-history) and similar code patterns (quinn-code-patterns)
  - Learns from dismissed comments (quinn-review-learnings) and
    suppresses low-signal patterns on future reviews
  - Explicitly designed to replace CodeRabbit per its reference doc

The release-tools `review-code` CLI was a bridge tool — added to bypass
clawpatch's OpenAI-Codex coupling so we could run Clawpatch-shaped
findings through the protoLabs gateway. With Quinn live, it's redundant
and removed in one shot rather than deprecated.

Removed:
  bin/review-code.mjs
  lib/code-review.mjs
  test/code-review.test.mjs
  docs/handoffs/2026-05-21-review-code.md

Updated:
  package.json    — drop bin entry, version 1.1.0 → 2.0.0
  .github/workflows/ci.yml — drop review-code lint/smoke steps
  README.md       — drop the "Model-backed code review" section

Consumers already migrated:
  protoLabsAI/protoMaker#3746
  protoLabsAI/escape-from-qud#109

Closes #9 (review-code: post sticky PR comment — no longer needed; Quinn
posts inline review comments natively).
@mabry1985 mabry1985 merged commit 4f2d02f into main May 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review-code: post sticky PR comment as part of the run (absorb post-review-findings.mjs)

1 participant