Skip to content

[FotMob] Added support for retrieving "Expected goals on target (xGOT)" stats #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zack-fathi wants to merge 2 commits into from
Closed

[FotMob] Added support for retrieving "Expected goals on target (xGOT)" stats #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
139caca
Add support for 'Expected goals on target (xGOT)' to read_team_match_…
zack-fathi Apr 1, 2025
e221f9b
style: auto format pre-commit
zack-fathi Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion soccerdata/fotmob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ def read_team_match_stats(
* 'Top stats'
* 'Shots'
* 'Expected goals (xG)'
* 'Expected goals on target (xGOT)'
* 'Passes'
* 'Defence'
* 'Duels'
Expand Down Expand Up @@ -410,12 +411,25 @@ def read_team_match_stats(

# Get stats types
all_stats = game_data["content"]["stats"]["Periods"]["All"]["stats"]

# create an alias for nested stats
alias_map = {
"Expected goals on target (xGOT)": "Expected goals (xG)",
}
parent_type = alias_map.get(stat_type, stat_type)

try:
selected_stats = next(stat for stat in all_stats if stat["title"] == stat_type)
selected_stats = next(stat for stat in all_stats if stat["title"] == parent_type)
except StopIteration:
raise ValueError(f"Invalid stat type: {stat_type}")

df_raw_stats = pd.DataFrame(selected_stats["stats"])

# xGOT filter
if stat_type == "Expected goals on target (xGOT)":
title_filter = "Expected goals on target (xGOT)"
df_raw_stats = df_raw_stats[df_raw_stats["title"] == title_filter]

game_teams = [game.home_team, game.away_team]
for i, team in enumerate(game_teams):
df_team_stats = df_raw_stats.copy()
Expand Down
11 changes: 10 additions & 1 deletion tests/test_FotMob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,16 @@ def test_read_schedule(fotmob_laliga: FotMob) -> None:
@pytest.mark.fails_gha()
@pytest.mark.parametrize(
"stat_type",
["Top stats", "Shots", "Expected goals (xG)", "Passes", "Defence", "Duels", "Discipline"],
[
"Top stats",
"Shots",
"Expected goals (xG)",
"Expected goals on target (xGOT)",
"Passes",
"Defence",
"Duels",
"Discipline",
],
)
def test_read_team_match_stats(fotmob_laliga: FotMob, stat_type: str) -> None:
assert isinstance(
Expand Down
Loading