[FotMob] Added support for retrieving "Expected goals on target (xGOT)" stats #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
read_team_match_statsto recognize and extract the"xG on target (xGOT)"field from within the"Expected goals (xG)"section.test_read_team_match_stats) to includestat_type="Expected goals on target (xGOT)".Closes #781 — This feature allows users to explicitly request xGOT data, which was previously included in the data but not directly accessible.
Note: CI failures are unrelated to this PR. The failing tests are in
FiveThirtyEightandSoFIFA, which were not touched in this PR. Errors appear to be caused by external data sources returning unexpected or malformed data (e.g., HTML instead of JSON).