Add ActionBar.Button for text button overflow support#8048
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 3f9f4ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: iansan5653 <2294248+iansan5653@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add text button overflow support for ActionBar
Add ActionBar.Button for text button overflow support
Jun 24, 2026
Contributor
|
jonrohan
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActionBar only supported
IconButtonchildren; text buttons (now common in GH design) had no first-class API and no overflow handling. This addsActionBar.Button, used likeActionBar.IconButton, that collapses into the overflow menu when space runs out.Changelog
New
ActionBar.Button— a textButtonsubcomponent (variant="invisible") that registers with the existing overflow mechanism. Useschildrenas the overflow menu label and forwards a componentleadingVisualas the menu item's leading icon.ActionBarButtonProps.WithTextButtons; docs metadata; unit tests.Changed
actionitems now render a leading visual only when an icon is present (text buttons may have none); item key switched fromlabelto the registryid. Internally, theactionChildPropsiconis now optional andlabelacceptsReactNode.Removed
Rollout strategy
Additive, backwards-compatible API.
Testing & Reviewing
Storybook →
Experimental/Components/ActionBar/Examples→WithTextButtons. Resize the container to verify buttons overflow into the menu, the label (and optional leading icon) render in the menu, anddisabledis respected. Unit coverage added inActionBar.test.tsx(render, click, disabled, keyboard).Merge checklist