Skip to content

refactor(props): call toLowerCase on name regardless of its current casing #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 1 commit into from
Jan 24, 2026
Merged

refactor(props): call toLowerCase on name regardless of its current casing #5003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/diff/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ export function setProperty(dom, name, value, oldValue, namespace) {
useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1'));

// Infer correct casing for DOM built-in events:
Copy link
Copy Markdown
Member

@rschristian rschristian Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that needs to be done here, but we probably should do away with this comment now that we're not inferring anything (and instead just assuming the vent matches DOM event conventions).

name = name.slice(2);
if (name[0].toLowerCase() != name[0]) name = name.toLowerCase();
name = name.slice(2).toLowerCase();

if (!dom._listeners) dom._listeners = {};
dom._listeners[name + useCapture] = value;
Expand Down
Loading