refactor(props): call toLowerCase on name regardless of its current casing #5003
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
rschristian
reviewed
Jan 23, 2026
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
The benches almost certainly don't cover this situation, the numbers returned shouldn't be too useful.
This PR just trades perf from lowercased event names as props and gives it to camelcased. Latter is probably more popular, so maybe this is a positive change?
rschristian
approved these changes
Jan 24, 2026
rschristian
reviewed
Jan 24, 2026
| else if (name[0] == 'o' && name[1] == 'n') { | ||
| useCapture = name != (name = name.replace(CAPTURE_REGEX, '$1')); | ||
|
|
||
| // Infer correct casing for DOM built-in events: |
Member
There was a problem hiding this comment.
Not something that needs to be done here, but we probably should do away with this comment now that we're not inferring anything (and instead just assuming the vent matches DOM event conventions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if benchmarks don't get negatively affected, we could save some bytes and perhaps even improve performance a bit