Licences param for go_library, go_binary and cgo_library#364
Merged
Conversation
jwong-beep
force-pushed
the
pump-licences-down
branch
from
67e5415 to
ab3be4c
Compare
jwong-beep
force-pushed
the
pump-licences-down
branch
from
ab3be4c to
a20b3a9
Compare
jwong-beep
force-pushed
the
pump-licences-down
branch
2 times, most recently
from
6008fd3 to
f7e88da
Compare
jwong-beep
changed the title
jwong-beep
force-pushed
the
pump-licences-down
branch
from
f7e88da to
3cb9e01
Compare
chrisnovakovic
approved these changes
Jul 3, 2026
Co-authored-by: Chris Novakovic <chris@chrisn.me.uk>
jwong-beep
force-pushed
the
pump-licences-down
branch
from
90ebe7e to
b57b35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
go_reporule generates aBUILDfile with ago_libraryper package in the repo. Due togo_librarycurrently not accepting alicencesparameter, in addition topukulintreplacing top level deps with package level deps, thelicencesparameter recorded in thego_repodoes not get passed down to these granular targets.Since the build graph is now depending on the packages of these repos instead of the repos, we'll need to pass licences down to the library and binary level so stamping can produce the accepted licences