Propagate licences to go_repo generated targets for stamping#365
Open
jwong-beep wants to merge 1 commit into
Open
Propagate licences to go_repo generated targets for stamping#365jwong-beep wants to merge 1 commit into
jwong-beep wants to merge 1 commit into
Conversation
jwong-beep
changed the title
jwong-beep
force-pushed
the
pump-licences-down-2
branch
3 times, most recently
from
40a22c7 to
4eae6e3
Compare
The go_repo rule generates a BUILD file with a go_library per package in the repo. If the licences are not passed to go_library, targets that depend directly on thes go_repo generated go_library targets will not have licences and accepted licences when stamped. This change introduces a new `--licence` flag to `please_go generate` so it can generate build rules for module packages that contain them.
jwong-beep
force-pushed
the
pump-licences-down-2
branch
from
4eae6e3 to
2f31b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #364
The approach is simply to take an extra parameter in
please_go generatecalled--licence, which can be supplied multiple times for modules that are multi-licenced.