Skip to content

Fix hardcoded build paths in .desktop Exec and TryExec #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Benibur wants to merge 1 commit into from
Closed

Fix hardcoded build paths in .desktop Exec and TryExec #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bin/bundle-appimage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ export OUTNAME="Ghostty-${GHOSTTY_VERSION}-${ARCH}.AppImage"
export DESKTOP="./ghostty-${GHOSTTY_VERSION}/zig-out/share/applications/com.mitchellh.ghostty.desktop"
export ICON="./ghostty-${GHOSTTY_VERSION}/zig-out/share/icons/hicolor/256x256/apps/com.mitchellh.ghostty.png"

# Fix Exec and TryExec paths: the build produces absolute paths from the build
# environment, which breaks desktop integration tools like appimaged that extract
# the .desktop file and use it as-is. Using just the binary name lets the AppImage
# runtime resolve it correctly.
sed -i 's|^TryExec=.*|TryExec=ghostty|' "$DESKTOP"
sed -i 's|^Exec=.*ghostty\(.*\)|Exec=ghostty\1|' "$DESKTOP"

./quick-sharun ./ghostty-${GHOSTTY_VERSION}/zig-out/bin/ghostty
cp -rf ./ghostty-${GHOSTTY_VERSION}/zig-out/share/* ./AppDir/share/
./quick-sharun --make-appimage
Expand Down
Loading