Fix hardcoded build paths in .desktop Exec and TryExec#127
Closed
Benibur wants to merge 1 commit intopkgforge-dev:mainfrom
Closed
Fix hardcoded build paths in .desktop Exec and TryExec#127Benibur wants to merge 1 commit intopkgforge-dev:mainfrom
Benibur wants to merge 1 commit intopkgforge-dev:mainfrom
Conversation
The Ghostty build produces a .desktop file with absolute paths from the build environment (e.g. /__w/ghostty-appimage/.../zig-out/bin/ghostty). When desktop integration tools like appimaged extract this .desktop file and install it on the user's system, TryExec fails because the path doesn't exist, causing the entry to be silently ignored by GNOME Shell. This replaces the absolute paths with just the binary name "ghostty", which the AppImage runtime resolves correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Hi, are you 100% appimaged was able to extract the desktop entry from this appimage? Because appimaged does not support DWARFS, so I find it very unlikely that it was able to extract the desktop entry to begin with. In the README we recommend that you use AM or AppManager to manage appimages, those two support dwarfs and work without issue with the current appimage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
.desktopfile embedded in the AppImage contains absolute paths from the CI build environment:Desktop integration tools like appimaged extract this
.desktopfile and install it in~/.local/share/applications/. Since theTryExecpath doesn't exist on the user's system, GNOME Shell silently ignores the entry — the app never appears in the Dash/Overview search.Fix
Replace absolute build paths with just the binary name
ghosttyinExecandTryExecbefore bundling the AppImage. The AppImage runtime resolves the binary correctly.Test
Before the fix, on Ubuntu 24.04 with GNOME Shell 46 + appimaged:
After manually creating a corrected
.desktopfile: