Skip to content

fix(marketing): show platform-appropriate commit shortcut on the website #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedankPurohit wants to merge 5 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(marketing): show platform-appropriate commit shortcut on the website #3644

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b89c0f
fix(marketing): show platform-appropriate commit shortcut on the website
VedankPurohit Jul 2, 2026
c9d5d02
Match app's Ctrl+Enter shortcut label
VedankPurohit Jul 2, 2026
8155288
Use return glyph in non-Mac shortcut badge
VedankPurohit Jul 2, 2026
744ae34
Keep shortcut fallback platform-scoped
VedankPurohit Jul 2, 2026
c84f374
Merge branch 'main' into fix/website-windows-shortcut-3526
VedankPurohit Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/marketing/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ const mobileEndorsementRows = [
<button class="pr-button">
<svg width="13" height="13" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="1.6" stroke-linecap="round" stroke-linejoin="round"><circle cx="6" cy="6" r="2.2"/><circle cx="6" cy="18" r="2.2"/><circle cx="18" cy="6" r="2.2"/><path d="M6 8v8M18 8v5a3 3 0 01-3 3h-3M13 13l-2 3 2 3"/></svg>
Commit &amp; push
<span class="pr-button-kbd">⌘⏎</span>
<span id="pr-button-kbd" class="pr-button-kbd">⌘⏎</span>
</button>
</div>
</div>
Expand Down Expand Up @@ -403,12 +403,14 @@ const mobileEndorsementRows = [
const label = document.getElementById("download-label");
const ctaBtn = document.getElementById("cta-download-btn") as HTMLAnchorElement | null;
const ctaLabel = document.getElementById("cta-download-label");
const kbd = document.getElementById("pr-button-kbd");

const platform = detectPlatform();
if (!platform) return;
document.documentElement.dataset.platform = platform.os;
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
if (label) label.textContent = platform.label;
if (ctaLabel) ctaLabel.textContent = platform.label;
if (kbd && platform.os !== "mac") kbd.textContent = "Ctrl ⏎";

try {
const release = await fetchLatestRelease();
Expand Down
Loading