Skip to content

fix(marketing): show platform-appropriate commit shortcut on the website#3644

Open
VedankPurohit wants to merge 5 commits into
pingdotgg:mainfrom
VedankPurohit:fix/website-windows-shortcut-3526
Open

fix(marketing): show platform-appropriate commit shortcut on the website#3644
VedankPurohit wants to merge 5 commits into
pingdotgg:mainfrom
VedankPurohit:fix/website-windows-shortcut-3526

Conversation

@VedankPurohit

@VedankPurohit VedankPurohit commented Jul 2, 2026

Copy link
Copy Markdown

Summary

  • Fixes [Bug]: Public website shows macOS shortcut on Windows #3526 by showing Ctrl ⏎ on the marketing demo button for detected Windows and Linux visitors.
  • Leaves the server-rendered ⌘⏎ default unchanged for macOS and unsupported platforms.
  • Reuses the homepage platform detection already used for download labels.

UI Changes

Before (Windows):
Before (Windows)

After (Windows):
After (Windows)

After (macOS, unchanged):
After (macOS unchanged)

Test plan

  • vp check
  • vp run typecheck
  • Refreshed the after-Windows screenshot from the local marketing page with a Windows user agent.

Note

Low Risk
Marketing-only copy on the homepage; no auth, data, or product runtime behavior changes.

Overview
The marketing homepage Commit & push demo no longer always shows the Mac shortcut. The keyboard hint span is given an id so client-side code can update it after the existing detectPlatform() logic runs.

On Windows and Linux, the label is set to Ctrl ⏎. macOS (and visitors with no detected platform) still get the server-rendered ⌘⏎ default.

Reviewed by Cursor Bugbot for commit c84f374. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show platform-appropriate keyboard shortcut on the marketing site commit button

The commit & push button on the marketing site homepage previously always showed the Mac keyboard shortcut. A script now detects the user's OS at runtime and sets the label to "Ctrl ⏎" for non-Mac platforms.

Macroscope summarized c84f374.

The hero's "Commit & push" button hardcoded the macOS shortcut (⌘⏎),
so Windows and Linux visitors saw the wrong keys. Reuse the existing
client-side platform detection in index.astro to swap the label to
"Ctrl ⏎" when the detected OS is not macOS. The server-rendered
default stays ⌘⏎.

Fixes pingdotgg#3526
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 12ff797a-289a-4c68-b4f7-73c7b8ddc0fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jul 2, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 2, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Simple marketing website UI fix that shows platform-appropriate keyboard shortcuts (⌘ for Mac, Ctrl for others). No product runtime impact - just display text on the website.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review July 2, 2026 05:51

Dismissing prior approval to re-evaluate c9d5d02

Comment thread apps/marketing/src/pages/index.astro Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 2, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review July 2, 2026 20:19

Dismissing prior approval to re-evaluate 8155288

Comment thread apps/marketing/src/pages/index.astro
Comment thread apps/marketing/src/pages/index.astro Outdated
@juliusmarminge juliusmarminge enabled auto-merge (squash) July 2, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Public website shows macOS shortcut on Windows

1 participant