Skip to content

Additional pagination on top of the table #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GreeenPeppper wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Additional pagination on top of the table #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@
<div class="twrapper">
<table class="people">
<thead>
<tr>
<th colspan="3" style="border-bottom: 1.5px solid #4F5B93; text-align: center !important;">
<?php if ($page > 1): ?>
<a class="pagination prev" href="?page=<?php echo $page-1?>">« Previous page</a>
<?php endif ?>
<span class="page"><?php echo $page ?></span>
<?php if ($x == 49): ?>
Copy link
Contributor

@salathe salathe Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $x is not yet defined here. Also, it will only be 49 after the foreach loop (when looping over a full "page" of users).

<a class="pagination next" href="?page=<?php echo ++$page?>">Next page »</a>
Copy link
Contributor

@salathe salathe Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mutating the $page variable here means that it has the wrong value when used (and incremented again) later on.

<?php endif ?>
</th>
</tr>
<tr>
<th></th>
<th>Username</th>
Expand Down