Additional pagination on top of the table#11
Open
GreeenPeppper wants to merge 1 commit intophp:masterfrom
Open
Additional pagination on top of the table#11GreeenPeppper wants to merge 1 commit intophp:masterfrom
GreeenPeppper wants to merge 1 commit intophp:masterfrom
Conversation
I've added an additional pagination bar on top of the table because I personally find it very annoying scrolling down the whole page to go to the next one
salathe
requested changes
Dec 31, 2020
| <a class="pagination prev" href="?page=<?php echo $page-1?>">« Previous page</a> | ||
| <?php endif ?> | ||
| <span class="page"><?php echo $page ?></span> | ||
| <?php if ($x == 49): ?> |
Contributor
There was a problem hiding this comment.
The variable $x is not yet defined here. Also, it will only be 49 after the foreach loop (when looping over a full "page" of users).
| <?php endif ?> | ||
| <span class="page"><?php echo $page ?></span> | ||
| <?php if ($x == 49): ?> | ||
| <a class="pagination next" href="?page=<?php echo ++$page?>">Next page »</a> |
Contributor
There was a problem hiding this comment.
Mutating the $page variable here means that it has the wrong value when used (and incremented again) later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an additional pagination bar on top of the table because I personally find it very annoying scrolling down the whole page to go to the next one