Expose original file descriptor in CliRunner#3244
Open
kdeldycke wants to merge 1 commit intopallets:stablefrom
Open
Expose original file descriptor in CliRunner#3244kdeldycke wants to merge 1 commit intopallets:stablefrom
CliRunner#3244kdeldycke wants to merge 1 commit intopallets:stablefrom
Conversation
kdeldycke
force-pushed
the
clirunner-fileno
branch
from
bcc1350 to
7de8209
Compare
Collaborator
Author
|
The fix in this PR has been tested and validated by the original reporter @ThomasLoke at #2865 (comment) . So I guess this one is ready to be reviewed and merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2865, a user realized that using standard library's
faulthandleris crashing inCliRunner. That's because inCliRunner's isolation,sys.stderris a_NamedTextIOWrapperaround aBytesIOand as such as nofileno().This PR gives
_NamedTextIOWrappera realfileno()so it can play nice with C-level consumers that need the original file descriptor, likefaulthandler,subprocess, C extensions, etc.Solution is inspired by pytest own's
capsysandcapfdmodes.This is an adjacent issue of #3139 and #3235, and fix #2865.