Skip to content

Fix warnings #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkeeter wants to merge 1 commit into from
+8 −8
Closed

Fix warnings #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions downstairs/src/extent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ impl Extent {
/// returned. Otherwise, the value in `ExtentReadResponse::data` is
/// guaranteed to be fully initialized and of the requested length.
#[instrument]
pub fn read(
pub(crate) fn read(
&mut self,
job_id: JobId,
req: ExtentReadRequest,
Expand All @@ -597,7 +597,7 @@ impl Extent {
}

#[instrument]
pub fn write(
pub(crate) fn write(
&mut self,
job_id: JobId,
write: &ExtentWrite,
Expand Down
4 changes: 2 additions & 2 deletions downstairs/src/region.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@ impl Region {
}

#[instrument]
pub fn region_write(
pub(crate) fn region_write(
&mut self,
writes: &RegionWrite,
job_id: JobId,
Expand Down Expand Up @@ -832,7 +832,7 @@ impl Region {
}

#[instrument]
pub fn region_read(
pub(crate) fn region_read(
&mut self,
req: &RegionReadRequest,
job_id: JobId,
Expand Down
8 changes: 4 additions & 4 deletions upstairs/src/downstairs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ impl Downstairs {
}

if self.gw_active.remove(&ds_id) {
self.acked_ids.push(ds_id);
self.acked_ids.enqueue(ds_id);
} else {
panic!("job {ds_id} not on gw_active list");
}
Expand Down Expand Up @@ -2405,7 +2405,7 @@ impl Downstairs {
);

if acked {
self.acked_ids.push(ds_id)
self.acked_ids.enqueue(ds_id);
} else {
self.gw_active.insert(ds_id);
}
Expand Down Expand Up @@ -2922,9 +2922,9 @@ impl Downstairs {
assert!(job.acked);

retired.push(id);
self.retired_ids.push(id);
self.retired_ids.enqueue(id);
let summary = job.io_summarize(id);
self.retired_jobs.push(summary);
self.retired_jobs.enqueue(summary);
for cid in ClientId::iter() {
self.clients[cid].retire_job(job);
}
Expand Down