Skip to content

Fix warnings#1907

Closed
mkeeter wants to merge 1 commit intomainfrom
mkeeter/fix-warnings
Closed

Fix warnings#1907
mkeeter wants to merge 1 commit intomainfrom
mkeeter/fix-warnings

Conversation

@mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Mar 16, 2026

  • ringbuffer::RingBuffer::push is deprecated
  • Fix warning about returned values being less public than functions, by making the functions less public

@mkeeter mkeeter requested a review from leftwo March 16, 2026 19:28
leftwo
leftwo approved these changes Mar 16, 2026
View reviewed changes
Copy link
Contributor

@leftwo leftwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

See also: #1904

@mkeeter
Copy link
Contributor Author

mkeeter commented Mar 16, 2026

#1904 looks more exhaustive, approved

@mkeeter mkeeter closed this Mar 16, 2026
@mkeeter mkeeter deleted the mkeeter/fix-warnings branch March 16, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leftwo leftwo leftwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkeeter @leftwo