Skip to content

local CLUSTER_ID check in CLUSTER_LIST. #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kishiguro wants to merge 2 commits into
base: master
Choose a base branch
from
Open

local CLUSTER_ID check in CLUSTER_LIST. #2237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee6957f
local CLUSTER_ID check in CLUSTER_LIST should be performed to non rou…
kishiguro Feb 11, 2020
0f74c46
Keep current logic for setting ignore.
kishiguro Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions pkg/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,25 +506,25 @@ func filterpath(peer *peer, path, old *table.Path) *table.Path {
ignore = false
}
if peer.isRouteReflectorClient() {
// RFC4456 8. Avoiding Routing Information Loops
// If the local CLUSTER_ID is found in the CLUSTER_LIST,
// the advertisement received SHOULD be ignored.
for _, clusterID := range path.GetClusterList() {
peer.fsm.lock.RLock()
rrClusterID := peer.fsm.peerInfo.RouteReflectorClusterID
peer.fsm.lock.RUnlock()
if clusterID.Equal(rrClusterID) {
log.WithFields(log.Fields{
"Topic": "Peer",
"Key": peer.ID(),
"ClusterID": clusterID,
"Data": path,
}).Debug("cluster list path attribute has local cluster id, ignore")
return nil
}
}
ignore = false
}
// RFC4456 8. Avoiding Routing Information Loops
// If the local CLUSTER_ID is found in the CLUSTER_LIST,
// the advertisement received SHOULD be ignored.
for _, clusterID := range path.GetClusterList() {
peer.fsm.lock.RLock()
rrClusterID := peer.fsm.peerInfo.RouteReflectorClusterID
peer.fsm.lock.RUnlock()
if clusterID.Equal(rrClusterID) {
log.WithFields(log.Fields{
"Topic": "Peer",
"Key": peer.ID(),
"ClusterID": clusterID,
"Data": path,
}).Debug("cluster list path attribute has local cluster id, ignore")
return nil
}
}
}

if ignore {
Expand Down